fix(broker): delete leaked JetStream consumers on rule subject change - #40
Merged
Conversation
Fixes issue where consumers leak/persist when a rule no longer references the consumer. This change will add new subscriptions and remove old ones which no longer have any consumers. Pre-existing ophans will need to be manually cleaned up. ` Signed-off-by: Daniel Michaels <dan@danielms.site>
Signed-off-by: Daniel Michaels <dan@danielms.site>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rule updates that change or remove a subject could leave JetStream durable consumers behind, and failed subscription startup could leave partial state behind. This PR makes those
updates atomic and ensures obsolete consumers are deleted when they are no longer referenced.
What changed
Notes