Fix UI freeze while loading clip#33
Merged
Merged
Conversation
danielchalmers
changed the title
danielchalmers
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
Selecting a clip waited for the existing playback stop/close path before the controller raised its loading state for the new clip. When Flyleaf cleanup was slow, the UI could appear frozen and the loading overlay did not render until after the expensive work had already completed.
Validation
dotnet test .\SentryReplay.slnxdotnet format .\SentryReplay.slnx --verify-no-changesUI Verification
Open the app, start playback, then click another clip in the sidebar. The loading overlay should appear immediately while the next clip gets ready.