Skip to content

fix: start/pause values for T2117 #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hfbauman wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: start/pause values for T2117 #428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions custom_components/robovac/vacuums/T2117.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ class T2117(RobovacModelDetails):
commands = {
RobovacCommand.START_PAUSE: {
"code": 2,
"values": {
"start": True,
"pause": False,
},
},
Comment on lines 21 to 28
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add/extend unit tests to cover the new boolean START_PAUSE mapping for T2117 (e.g., assert getRoboVacCommandValue(START_PAUSE, "start") is True and "pause" is False). The repo already has per-model command mapping tests (see tests/test_vacuum/test_t2118_command_mappings.py:test_t2118_start_pause_values), but T2117 doesn’t appear to be covered yet, so this regression-prone behavior would benefit from a dedicated test file.

Copilot uses AI. Check for mistakes.
RobovacCommand.DIRECTION: {
"code": 3,
Expand Down
Loading