perf(compose): optimize OnboardingScreen UI and object allocations - #860
perf(compose): optimize OnboardingScreen UI and object allocations#860yacosta738 wants to merge 1 commit into
Conversation
- Extract private top-level shape constants for OnboardingSkipButton, OnboardingMainContent, and ProgressBar. - Memoize the modifier chain and vertical gradient in onboardingLayoutModifier using remember. - Use remember for linear and radial brushes in OnboardingIconDisplay. - Optimize FuturisticProgressIndicator by hoisting the active gradient out of the repeat loop and using SolidColor for the inactive state. These changes reduce ephemeral object allocations and improve interaction smoothness during the onboarding flow.
Deploying corvus with
|
| Latest commit: |
003b586
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d8d8b9cc.corvus-42x.pages.dev |
| Branch Preview URL: | https://perf-onboarding-ui-optimizat-zhsv.corvus-42x.pages.dev |
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
1 participant
This PR implements several performance optimizations for the
OnboardingScreenin the Compose Multiplatform application.Key improvements:
RoundedCornerShapeconstants to avoid repeated allocations during recomposition.rememberto expensiveModifierchains andBrushobjects (gradients) across all onboarding components.FuturisticProgressIndicator's rendering loop by hoisting stable assets and replacing redundant gradient calculations with a simplerSolidColorbackground.Performance impact:
Verified with
./gradlew :composeApp:spotlessCheckand./gradlew :composeApp:jvmTest.PR created automatically by Jules for task 13926332317086740088 started by @yacosta738