Skip to content

ENG-1869 - Bump bundler to v2 - #130

Merged
baueric merged 2 commits into
masterfrom
eng-1869-bump-bundler-to-v2
Jan 26, 2026
Merged

ENG-1869 - Bump bundler to v2#130
baueric merged 2 commits into
masterfrom
eng-1869-bump-bundler-to-v2

Conversation

@baueric

@baueric baueric commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

Linear issue: https://linear.app/daisybill/issue/ENG-1869/bump-bundler-to-v2

Reviewers

Primary:

Summary of Changes

Pre-review Checklist

  • Self-review with explanations and questions
  • Write automated tests for new functionality

Code Review Checklist

To be completed by the primary reviewer listed above

  • All automated checks are passing (CodeClimate, CircleCI, etc)
  • Set up branch locally and product review
  • Check for any authentication or authorization changes. If there are any, ensure multiple code and product reviewers have been assigned with a note that their review is required.
  • Check for any usage of authorized_user and authenticated_user and ensure used correctly
  • Verify that queries on large tables are bounded and not aggregating counts or returning all records without pagination and limits (ex. datatables that could return many records are AJAX)
  • Ensure that any code whose performance can only accurately be measured in production is behind a feature flag
  • Verify that any migrations or data fixes follow best practices, especially in regards to changes affecting large database tables
  • Ensure that queue priority is correct for any jobs included in this pull request
  • Create Heroku review app
  • Assign Product Reviewer

Product Review Notes

Screenshots or Demo Video

@baueric baueric self-assigned this Mar 12, 2025
baueric added a commit that referenced this pull request Mar 12, 2025
@baueric
[#130] Update ruby and dependencies
aba31cf
@baueric
baueric force-pushed the eng-1869-bump-bundler-to-v2 branch from 1045bf1 to aba31cf Compare March 12, 2025 13:58
@baueric
baueric force-pushed the eng-1869-bump-bundler-to-v2 branch from aba31cf to 11ed1bc Compare March 12, 2025 13:59
@baueric

baueric commented Mar 24, 2025

Copy link
Copy Markdown
Contributor Author

@BrianBorge I'm closing this one

@baueric baueric closed this Mar 24, 2025
@baueric baueric reopened this Jan 21, 2026
baueric added a commit that referenced this pull request Jan 21, 2026
@baueric
[#130] Add VCR cassette for attachment response and update spec_helpe…
12dd3b7 
…r to prevent recording new episodes

- Created a new VCR cassette for the attachment response from the Daisybill API, capturing the HTTP interaction and response details.
- Updated the VCR configuration in spec_helper.rb to set the default cassette options to not record new episodes, ensuring existing cassettes are used without modification.
@baueric
baueric requested a review from BrianBorge January 21, 2026 10:28
@baueric
baueric marked this pull request as ready for review January 21, 2026 10:28
@baueric

baueric commented Jan 21, 2026

Copy link
Copy Markdown
Contributor Author

@BrianBorge reopening and finishing this one to get rid of the critical dependabot alert

baueric added a commit that referenced this pull request Jan 21, 2026
@baueric
[#130] Add VCR cassette for attachment response and update spec_helpe…
863d60d 
…r to prevent recording new episodes

- Created a new VCR cassette for the attachment response from the Daisybill API, capturing the HTTP interaction and response details.
- Updated the VCR configuration in spec_helper.rb to set the default cassette options to not record new episodes, ensuring existing cassettes are used without modification.
@baueric
baueric force-pushed the eng-1869-bump-bundler-to-v2 branch from 12dd3b7 to 863d60d Compare January 21, 2026 10:32
baueric added a commit that referenced this pull request Jan 21, 2026
@baueric
[#130] Add VCR cassette for attachment response and update spec_helpe…
6c21959 
…r to prevent recording new episodes

- Created a new VCR cassette for the attachment response from the Daisybill API, capturing the HTTP interaction and response details.
- Updated the VCR configuration in spec_helper.rb to set the default cassette options to not record new episodes, ensuring existing cassettes are used without modification.
@baueric
baueric force-pushed the eng-1869-bump-bundler-to-v2 branch from 863d60d to 6c21959 Compare January 21, 2026 12:50
BrianBorge
BrianBorge reviewed Jan 21, 2026
View reviewed changes
Comment thread spec/spec_helper.rb Outdated
config.cassette_library_dir = "#{DaisybillApi::ROOT}/spec/fixtures/vcr"
config.hook_into :webmock
config.default_cassette_options = { :record => :new_episodes }
config.default_cassette_options = { :record => :none }

@BrianBorge BrianBorge Jan 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this option do?

@baueric baueric Jan 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I can roll that back, it was changed while trying to fix the vcr files

@baueric
[#130] Add VCR cassette for attachment response and update spec_helpe…
78a6d10 
…r to prevent recording new episodes

- Created a new VCR cassette for the attachment response from the Daisybill API, capturing the HTTP interaction and response details.
- Updated the VCR configuration in spec_helper.rb to set the default cassette options to not record new episodes, ensuring existing cassettes are used without modification.
@baueric
baueric force-pushed the eng-1869-bump-bundler-to-v2 branch from 6c21959 to 78a6d10 Compare January 21, 2026 14:31
@baueric
baueric merged commit 9e26e62 into master Jan 26, 2026
1 check passed
baueric added a commit that referenced this pull request Jan 26, 2026
@baueric
[#130] Update ruby and dependencies
733de9c
BrianBorge added a commit that referenced this pull request Mar 24, 2026
@BrianBorge @claude
Bump version to 0.2.0 and update changelog
2d5fbff 
0.1.9 was released as a hotfix on the v0.1.7 branch for Ruby 2
consumers. This branch (off master) includes the Ruby/dependency
updates from PR #130 plus the GET params fix, released as 0.2.0.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@BrianBorge BrianBorge mentioned this pull request Mar 24, 2026
Merged
3 tasks
benliscio pushed a commit that referenced this pull request Mar 24, 2026
@BrianBorge @claude
v0.2.0 - Ruby/dependency updates + GET params fix (#131)
93955cc 
* [#131] Fix GET requests sending params in body instead of query string

GET requests were including parameters as a request body payload, which
caused WAF to block them as anomalous. Params are now sent as URL query
string parameters for GET requests while preserving body payload behavior
for POST/PATCH/DELETE.

Bump version to 0.1.9.

* Bump version to 0.2.0 and update changelog

0.1.9 was released as a hotfix on the v0.1.7 branch for Ruby 2
consumers. This branch (off master) includes the Ruby/dependency
updates from PR #130 plus the GET params fix, released as 0.2.0.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrianBorge BrianBorge BrianBorge approved these changes

Assignees

@baueric baueric

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@baueric @BrianBorge