feat(feed-settings): swap Happening Now Switch for placement dropdown#6031
Merged
Conversation
Replaces the binary Pin Happening Now toggle with a 3-option Dropdown (Default / Pin to top / Disabled) backed by the new highlightsPlacement Settings flag. Lets users hide the Happening Now card entirely, not just pick between random vs pinned placement. The previous highlightsFirstEnabled flag is gone; SidebarSettingsFlags exposes the new key as Highlights (renamed to avoid shadowing the HighlightsPlacement value enum).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some users want to disable the Happening Now card altogether, not just toggle between random vs pinned placement. Replaces the binary Switch in Feed Settings → General with a 3-option Dropdown backed by the new
highlightsPlacementenum Settings flag.Options shown to the user:
Wire-up
SettingsFlags.highlightsFirstEnabled(bool) →SettingsFlags.highlightsPlacement('default' | 'pinned' | 'disabled')SidebarSettingsFlags.HighlightsFirstEnabled→SidebarSettingsFlags.Highlights(renamed to avoid shadowing theHighlightsPlacementvalue enum)LogEvent.ToggleHighlightsFirst→LogEvent.SetHighlightsPlacementwithtarget_idcarrying the chosen placement valueCompanion API PR: dailydotdev/daily-api#3867 (which also supersedes the in-flight #3866).
Test plan
pnpm --filter @dailydotdev/sharedlint on touched files — cleanpnpm run typecheck:strict:changed— cleanPreview domain
https://feat-highlights-placement-dropdo.preview.app.daily.dev