allow setting the completions menu sorter#39
Open
justinkb wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
an application using isocline might want arbitrarily complex sorting rules for its completions, say, based on Markov chains or even a neural network. or the application might wanna allow its users to pin certain common completions at the top.
in any case, if the application had already done the domain specific sorting before the completions are being passed to isocline, let's give them the option to make isocline not override that sorting. you've wisely decoupled that completions menu sorting from the prefix finding all along, so this change is perfectly safe.
kept this simple, allowing setting the sorter to NULL, but we might also provide other builtin sorters users can pick from if they don't want the case insensitive shortlex.