Skip to content

work/: triage against shipped main (#168, #155, #165, #132, #158)#171

Merged
cboos merged 1 commit into
mainfrom
dev/work-cleanup
May 25, 2026
Merged

work/: triage against shipped main (#168, #155, #165, #132, #158)#171
cboos merged 1 commit into
mainfrom
dev/work-cleanup

Conversation

@cboos
Copy link
Copy Markdown
Collaborator

@cboos cboos commented May 25, 2026

Summary

work/ had accumulated a few plan docs whose contents have since landed. Triage per monk's #3198 mail-thread (federation-internal), executed for the three shipped-cleanly cases. The plugin-system RFC (work/tool-renderer-plugins.md) and still-unshipped plans stay untouched in this PR; they belong to a separate phase.

  • DELETE work/async-agents.md — fully shipped in PR Support async agents (#90) #132 (294ed3b) with the cross-link follow-up in PR Cross-link TaskOutput / TaskUpdate headers back to their spawn (#154) #158 (1ab9f13). Content reflected in dev-docs/agents.md.
  • SHRINK work/rendering-next.md — drop the §2 ✅ COMPLETED signature-unification subsection (ancient history) and §3 "Additional Tool Output Parsers" (GlobOutput / GrepOutput / WebSearchOutput / WebFetchOutput all live in models.py now). Keep the recursive-template / visitor-pattern / performance speculative sections. Renumbered survivors.
  • SHRINK work/obsidian-friendly-output.md — the main implementation shipped in PR Obsidian-friendly output: --output dir + --expand-paths + --filter-path (#151) #155 (8de5b89); per-message Markdown timestamps in PR Per-message timestamps in Markdown output (#160) #165 (68e5bfb); --combined yes/no/only + --expand-paths bullet-list Markdown index also shipped. Drop all that. Retain the seven open follow-ups (cache-freshness destination-awareness, archived projects with --output, the absolute---filter-path-without---expand-paths silent-exclude footgun, --filter-path auto-implying --all-projects, --expand-paths for single-session, --dry-run mode, plus Obsidian frontmatter / wikilinks / peek-debug-logging / symlinks).

Net diff: 3 files changed, 29 insertions, 728 deletions.

Untouched (still unshipped or shipped-but-pending follow-up): work/refactor-reindex-with-ghosting.md, work/session-state-propagation.md, work/tool-renderer-plugins.md (the RFC will graduate to dev-docs/plugins.md only once PR #169 merges — phase 2).

Test plan

  • No code changes; existing inbound links from dev-docs/{dag,messages}.md to rendering-next.md remain valid (the file still exists, just shrunk).
  • just ci clean (format / test-all / ruff / pyright / ty).
  • No links to async-agents.md or obsidian-friendly-output.md from anywhere else in the repo (verified via rg).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated internal planning documents to reflect implementation progress and remaining follow-up items.
    • Removed completed planning documentation.

Review Change Stack

`work/` had accumulated a few plan docs whose contents have since
landed. Triage per main #3198, executed for the three
shipped-cleanly cases (the plugin-system RFC + the still-unshipped
docs stay untouched in this PR — they belong to a separate phase).

- **DELETE** `work/async-agents.md` — fully shipped in PR #132
  (`294ed3b`) with the cross-link follow-up in PR #158
  (`1ab9f13`). Content reflected in `dev-docs/agents.md`.

- **SHRINK** `work/rendering-next.md` — drop the §2 ✅ COMPLETED
  signature-unification subsection (ancient history) and §3
  "Additional Tool Output Parsers" (`GlobOutput` / `GrepOutput` /
  `WebSearchOutput` / `WebFetchOutput` all live in `models.py`
  now). Keep §1 (recursive template), §2 (visitor), and §3
  (performance) — still speculative. Renumbered the survivors.

- **SHRINK** `work/obsidian-friendly-output.md` — the main
  implementation shipped in PR #155 (`8de5b89`); per-message
  Markdown timestamps shipped in PR #165 (`68e5bfb`); the
  `--combined yes/no/only` flag and the `--expand-paths`
  bullet-list Markdown index both shipped too. Drop all of that;
  retain the seven open follow-ups (cache-freshness destination-
  awareness, archived projects with `--output`, the absolute-
  `--filter-path`-without-`--expand-paths` silent-exclude
  footgun, `--filter-path` auto-implying `--all-projects`,
  `--expand-paths` for single-session, `--dry-run` mode, plus
  Obsidian frontmatter / wikilinks / peek-debug-logging /
  symlinks).

Untouched (still unshipped or shipped-but-pending follow-up):
`work/refactor-reindex-with-ghosting.md`,
`work/session-state-propagation.md`,
`work/tool-renderer-plugins.md` (the RFC graduates to
`dev-docs/plugins.md` only once PR #169 merges — phase 2).

No code changes; existing inbound links from
`dev-docs/{dag,messages}.md` to `rendering-next.md` remain valid
(the file still exists, just shrunk).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3ebbf4ce-1f70-47bf-827e-80d153a862be

📥 Commits

Reviewing files that changed from the base of the PR and between f4b2ea9 and 66fdc6b.

📒 Files selected for processing (3)
  • work/async-agents.md
  • work/obsidian-friendly-output.md
  • work/rendering-next.md
💤 Files with no reviewable changes (1)
  • work/async-agents.md

📝 Walkthrough

Walkthrough

This PR updates project planning documentation to reflect shipped implementations. The obsidian-friendly-output document transitions from feature planning to post-implementation follow-ups, recording PR deliveries and remaining tasks. Completed work is cleaned up from rendering-next, and async-agents planning is archived.

Changes

Documentation Cleanup and Follow-up Tracking

Layer / File(s) Summary
Obsidian-friendly output: post-implementation follow-ups
work/obsidian-friendly-output.md
Document revised from issue planning to post-implementation follow-ups. Header and top sections now record that the main Obsidian-friendly output feature shipped (PR #155) and Markdown timestamps shipped (PR #165). New "Open follow-ups" section documents remaining ergonomics and correctness gaps: cache freshness checks, archived project handling, absolute --filter-path without --expand-paths footgun (with proposed auto-imply --expand-paths remedy), and additional CLI feature ideas (--filter-path implies --all-projects, --expand-paths for single-session exports, --dry-run mode). Consolidated "other open items" list covers frontmatter, wikilinks, timestamp follow-up, debug logging, and symlink-based projection.
Cleanup: removing completed items
work/async-agents.md, work/rendering-next.md
Async-agents planning document is archived (no new content observed). Rendering-next document removes the "✅ COMPLETED: Consistent (obj, message) Signatures" and "Additional Tool Output Parsers" sections; "Performance Optimization" heading is renumbered to section 3.

🐰 Through the planning docs I hop,
Crossed-off items make clean slate tops—
Obsidian output shipped with glee,
Follow-ups now clear as can be,
Async agents rest, their work's complete. 📋✨

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main objective: triaging and cleaning up work/ planning documents by removing or shrinking files whose content has already shipped in the specified PRs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev/work-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cboos cboos merged commit 9e81cd4 into main May 25, 2026
11 checks passed
@cboos cboos deleted the dev/work-cleanup branch May 25, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant