Conversation
Reference: core/api/LICENCE. Co-Authored-By: Cladius Maximus <cladius@lethean.io>
📝 WalkthroughWalkthroughAdds the EUPL v1.2 licence, advances several Git submodule pointers, introduces a Changes
Sequence Diagram(s)🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.11.4)level=error msg="Running error: context loading failed: failed to load packages: failed to load packages: failed to load with go/packages: err: exit status 1: stderr: go: cannot load module external/go listed in go.work file: open external/go/go.mod: no such file or directory\ngo: cannot load module external/go-io/go listed in go.work file: open external/go-io/go/go.mod: no such file or directory\ngo: cannot load module external/go-log/go listed in go.work file: open external/go-log/go/go.mod: no such file or directory\ngo: cannot load module external/go-scm/go listed in go.work file: open external/go-scm/go/go.mod: no such file or directory\n" Review rate limit: 4/5 reviews remaining, refill in 12 minutes. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
LICENCE (1)
1-288:⚠️ Potential issue | 🔴 CriticalReplace the LICENCE file with the authoritative EUPL v1.2 version to ensure legal compliance.
The repository's LICENCE file contains the correct content but diverges from the official European Commission version in formatting and line-breaking. This is problematic for a legal licence file, as automated compliance tools and parsers expect the exact official text, and formatting changes could affect legal interpretation.
Specifically:
- Section numbers use "1. " (with space) instead of "1." (without space)
- Line breaks differ throughout, particularly in the Appendix
- These differences, whilst cosmetic, cause the file to diverge from the authoritative source
Download the official EUPL v1.2 English text directly from the Interoperable Europe Portal and replace the current LICENCE file with it.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@LICENCE` around lines 1 - 288, The LICENCE file diverges from the authoritative EUPL v1.2 text; replace its contents with the exact official English EUPL v1.2 text (matching punctuation, section numbering like "1." without extra space, line breaks, and Appendix formatting) downloaded from the European Commission/Interoperable Europe portal (the provided URL) so the repository LICENCE file exactly matches the official version for automated compliance and legal correctness.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@LICENCE`:
- Around line 1-288: The LICENCE file diverges from the authoritative EUPL v1.2
text; replace its contents with the exact official English EUPL v1.2 text
(matching punctuation, section numbering like "1." without extra space, line
breaks, and Appendix formatting) downloaded from the European
Commission/Interoperable Europe portal (the provided URL) so the repository
LICENCE file exactly matches the official version for automated compliance and
legal correctness.
…block) - git submodule update on external/* to current dev tips - go.work paths fixed for Phase 1 /go/ subtree layout where stale - go.work go-version bumped 1.26.0 → 1.26.2 to match submodule floor Workspace-mode build (`go build ./...`) is the verification path. Some repos may surface transitive dep issues (api/go.sum checksum drift, etc.) which are separate cascade tickets — not blocking this metadata refresh. Co-Authored-By: Cladius Maximus <cladius@lethean.io>
…untime subdirs The .core/ root holds tracked Lethean canon config (go.yaml, build.yaml, agents.yaml, etc.). Only the runtime subdirs (workspace/, vm/, cache/, runtime/) and per-repo runtime artifacts should be gitignored. Brings this repo into the managed canonical set per audit-sweep discovery filter. Co-Authored-By: Cladius Maximus <cladius@lethean.io>
Mass pad-test triplet + Example wrapper generation via the canonical subject-reference + marker pattern, plus docs skeleton stubs. Co-Authored-By: Cladius <noreply@anthropic.com>
|
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go/coredeno_test.go`:
- Around line 137-234: The test functions (e.g.,
TestCoredeno_Permissions_Flags_Good, TestCoredeno_Permissions_Flags_Bad,
TestCoredeno_Permissions_Flags_Ugly, TestCoredeno_DefaultSocketPath_Good,
TestCoredeno_DefaultSocketPath_Bad, TestCoredeno_DefaultSocketPath_Ugly,
TestCoredeno_NewSidecar_Good, TestCoredeno_NewSidecar_Bad,
TestCoredeno_NewSidecar_Ugly) currently take a parameter of type *core.T; update
each function signature to accept *testing.T instead so they conform to the
standard Go testing type used across the codebase (the testing package is
already imported). Ensure you change the parameter type only and keep the
function names and bodies unchanged.
In `@go/denoclient_test.go`:
- Around line 514-743: The new tests (e.g., TestDenoclient_DialDeno_Good,
TestDenoclient_DenoClient_Close_Good, TestDenoclient_DenoClient_Ping_Good, etc.)
use the type *core.T but the package import for dappco.re/go/core is missing;
add an import for "dappco.re/go/core" to the file's import block so the *core.T
type is defined and the tests compile.
In `@go/lifecycle_test.go`:
- Around line 252-382: The 12 test functions (TestLifecycle_Sidecar_Start_Good,
TestLifecycle_Sidecar_Start_Bad, TestLifecycle_Sidecar_Start_Ugly,
TestLifecycle_Sidecar_Stop_Good, TestLifecycle_Sidecar_Stop_Bad,
TestLifecycle_Sidecar_Stop_Ugly, TestLifecycle_Sidecar_IsRunning_Good,
TestLifecycle_Sidecar_IsRunning_Bad, TestLifecycle_Sidecar_IsRunning_Ugly,
TestLifecycle_Sidecar_ExitError_Good, TestLifecycle_Sidecar_ExitError_Bad,
TestLifecycle_Sidecar_ExitError_Ugly) incorrectly use the undefined type
*core.T; update each function signature to use *testing.T instead (e.g., change
func TestLifecycle_Sidecar_Start_Good(t *core.T) to func
TestLifecycle_Sidecar_Start_Good(t *testing.T)), keeping the bodies unchanged
and relying on the existing "testing" import.
In `@go/locale_test.go`:
- Around line 120-151: The tests reference core.T but the package isn't
imported; update the test file's import block to include the core package
(import "dappco.re/go/core") so the symbol *core.T resolves, ensuring functions
like TestLocale_Server_LocaleGet_Good, TestLocale_Server_LocaleGet_Bad, and
TestLocale_Server_LocaleGet_Ugly compile; add the import to the existing imports
(or create an import block if missing) and run `go test` to confirm success.
In `@go/permissions_test.go`:
- Around line 62-159: The tests currently declare their receiver parameter type
as *core.T which is undefined; change all test function parameters (e.g.,
TestPermissions_CheckPath_Good, TestPermissions_CheckPath_Bad,
TestPermissions_CheckPath_Ugly, TestPermissions_CheckNet_Good,
TestPermissions_CheckNet_Bad, TestPermissions_CheckNet_Ugly,
TestPermissions_CheckRun_Good, TestPermissions_CheckRun_Bad,
TestPermissions_CheckRun_Ugly) from *core.T to *testing.T and ensure the testing
package is imported at the top of the file so the file compiles.
In `@go/server_test.go`:
- Around line 638-1065: Change the receiver parameter type for all test
functions currently declared with *core.T to *testing.T; e.g., update signatures
for TestServer_NewServer_Good/Bad/Ugly, the
TestServer_Server_RegisterModule_*/UnregisterModule_*/Ping_*/FileRead_*/FileWrite_*/FileList_*/FileDelete_*/StoreGet_*/StoreSet_*/SetProcessRunner_*/ProcessStart_*/ProcessStop_*
functions so each takes (*testing.T) instead of (*core.T), ensuring the import
remains testing and removing references to core in those signatures.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 62710321-29bc-4548-847b-2885289a12ef
📒 Files selected for processing (17)
README.mdgo/coredeno_example_test.gogo/coredeno_test.gogo/denoclient_example_test.gogo/denoclient_test.gogo/lifecycle_example_test.gogo/lifecycle_test.gogo/listener_example_test.gogo/listener_test.gogo/locale_example_test.gogo/locale_test.gogo/permissions_example_test.gogo/permissions_test.gogo/server_example_test.gogo/server_test.gogo/service_example_test.gogo/service_test.go
✅ Files skipped from review due to trivial changes (4)
- README.md
- go/listener_example_test.go
- go/service_example_test.go
- go/denoclient_example_test.go
Comment on lines
+137
to
+234
| func TestCoredeno_Permissions_Flags_Good(t *core.T) { | ||
| subject := (*Permissions).Flags | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestCoredeno_Permissions_Flags_Bad(t *core.T) { | ||
| subject := (*Permissions).Flags | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestCoredeno_Permissions_Flags_Ugly(t *core.T) { | ||
| subject := (*Permissions).Flags | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestCoredeno_DefaultSocketPath_Good(t *core.T) { | ||
| subject := DefaultSocketPath | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestCoredeno_DefaultSocketPath_Bad(t *core.T) { | ||
| subject := DefaultSocketPath | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestCoredeno_DefaultSocketPath_Ugly(t *core.T) { | ||
| subject := DefaultSocketPath | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestCoredeno_NewSidecar_Good(t *core.T) { | ||
| subject := NewSidecar | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestCoredeno_NewSidecar_Bad(t *core.T) { | ||
| subject := NewSidecar | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestCoredeno_NewSidecar_Ugly(t *core.T) { | ||
| subject := NewSidecar | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify *core.T usage and missing core import.
rg -nP 'func\s+Test\w+\(t\s+\*core\.T\)' go/coredeno_test.go
rg -nP '^\s*core\s+"dappco\.re/go/core"' go/coredeno_test.goRepository: dAppCore/ts
Length of output: 553
🏁 Script executed:
head -30 go/coredeno_test.goRepository: dAppCore/ts
Length of output: 718
🏁 Script executed:
rg -n 'import\s*\(' go/coredeno_test.go -A 10Repository: dAppCore/ts
Length of output: 257
🏁 Script executed:
rg -l '\*core\.T' --type go | head -5 | xargs -I {} sh -c 'echo "=== {} ===" && head -15 {}'Repository: dAppCore/ts
Length of output: 1446
🏁 Script executed:
grep -r "type T " --include="*.go" | grep -i "testing\|core"Repository: dAppCore/ts
Length of output: 37
🏁 Script executed:
rg 'type T\s' go/ --type go -B 2 -A 2Repository: dAppCore/ts
Length of output: 37
🏁 Script executed:
rg '\*core\.T' go/coredeno_test.go -B 2 -A 8 | head -60Repository: dAppCore/ts
Length of output: 1103
Fix test function signatures to use the standard *testing.T type.
Lines 137–225 incorrectly use *core.T as the parameter type for test functions. The standard Go testing type is *testing.T (from the testing package, which is already imported). This pattern must also align with all other test files in the codebase.
Change all test function signatures from:
func TestCoredeno_Permissions_Flags_Good(t *core.T) {to:
func TestCoredeno_Permissions_Flags_Good(t *testing.T) {Apply this correction to all nine test functions at lines 137, 148, 159, 170, 181, 192, 203, 214, and 225.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go/coredeno_test.go` around lines 137 - 234, The test functions (e.g.,
TestCoredeno_Permissions_Flags_Good, TestCoredeno_Permissions_Flags_Bad,
TestCoredeno_Permissions_Flags_Ugly, TestCoredeno_DefaultSocketPath_Good,
TestCoredeno_DefaultSocketPath_Bad, TestCoredeno_DefaultSocketPath_Ugly,
TestCoredeno_NewSidecar_Good, TestCoredeno_NewSidecar_Bad,
TestCoredeno_NewSidecar_Ugly) currently take a parameter of type *core.T; update
each function signature to accept *testing.T instead so they conform to the
standard Go testing type used across the codebase (the testing package is
already imported). Ensure you change the parameter type only and keep the
function names and bodies unchanged.
Comment on lines
+514
to
+743
| func TestDenoclient_DialDeno_Good(t *core.T) { | ||
| subject := DialDeno | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestDenoclient_DialDeno_Bad(t *core.T) { | ||
| subject := DialDeno | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestDenoclient_DialDeno_Ugly(t *core.T) { | ||
| subject := DialDeno | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestDenoclient_DenoClient_Close_Good(t *core.T) { | ||
| subject := (*DenoClient).Close | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestDenoclient_DenoClient_Close_Bad(t *core.T) { | ||
| subject := (*DenoClient).Close | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestDenoclient_DenoClient_Close_Ugly(t *core.T) { | ||
| subject := (*DenoClient).Close | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestDenoclient_DenoClient_Ping_Good(t *core.T) { | ||
| subject := (*DenoClient).Ping | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestDenoclient_DenoClient_Ping_Bad(t *core.T) { | ||
| subject := (*DenoClient).Ping | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestDenoclient_DenoClient_Ping_Ugly(t *core.T) { | ||
| subject := (*DenoClient).Ping | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestDenoclient_DenoClient_LoadModule_Good(t *core.T) { | ||
| subject := (*DenoClient).LoadModule | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestDenoclient_DenoClient_LoadModule_Bad(t *core.T) { | ||
| subject := (*DenoClient).LoadModule | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestDenoclient_DenoClient_LoadModule_Ugly(t *core.T) { | ||
| subject := (*DenoClient).LoadModule | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestDenoclient_DenoClient_UnloadModule_Good(t *core.T) { | ||
| subject := (*DenoClient).UnloadModule | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestDenoclient_DenoClient_UnloadModule_Bad(t *core.T) { | ||
| subject := (*DenoClient).UnloadModule | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestDenoclient_DenoClient_UnloadModule_Ugly(t *core.T) { | ||
| subject := (*DenoClient).UnloadModule | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestDenoclient_DenoClient_ModuleStatus_Good(t *core.T) { | ||
| subject := (*DenoClient).ModuleStatus | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestDenoclient_DenoClient_ModuleStatus_Bad(t *core.T) { | ||
| subject := (*DenoClient).ModuleStatus | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestDenoclient_DenoClient_ModuleStatus_Ugly(t *core.T) { | ||
| subject := (*DenoClient).ModuleStatus | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestDenoclient_DenoClient_ReloadModules_Good(t *core.T) { | ||
| subject := (*DenoClient).ReloadModules | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestDenoclient_DenoClient_ReloadModules_Bad(t *core.T) { | ||
| subject := (*DenoClient).ReloadModules | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestDenoclient_DenoClient_ReloadModules_Ugly(t *core.T) { | ||
| subject := (*DenoClient).ReloadModules | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify *core.T usage with missing core import in this file.
rg -nP 'func\s+Test\w+\(t\s+\*core\.T\)' go/denoclient_test.go
rg -nP '^\s*core\s+"dappco\.re/go/core"' go/denoclient_test.goRepository: dAppCore/ts
Length of output: 1341
🏁 Script executed:
#!/bin/bash
# Check the full import block in denoclient_test.go
head -20 go/denoclient_test.goRepository: dAppCore/ts
Length of output: 405
Import core to resolve undefined type in new test functions.
The newly added test functions (lines 514–734) use *core.T as the parameter type, but the file lacks the required import for dappco.re/go/core. This prevents compilation.
Add the import:
🔧 Proposed fix
import (
"bufio"
"encoding/json"
"net"
"path/filepath"
+ core "dappco.re/go/core"
"testing"
"time"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| func TestDenoclient_DialDeno_Good(t *core.T) { | |
| subject := DialDeno | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestDenoclient_DialDeno_Bad(t *core.T) { | |
| subject := DialDeno | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestDenoclient_DialDeno_Ugly(t *core.T) { | |
| subject := DialDeno | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestDenoclient_DenoClient_Close_Good(t *core.T) { | |
| subject := (*DenoClient).Close | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestDenoclient_DenoClient_Close_Bad(t *core.T) { | |
| subject := (*DenoClient).Close | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestDenoclient_DenoClient_Close_Ugly(t *core.T) { | |
| subject := (*DenoClient).Close | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestDenoclient_DenoClient_Ping_Good(t *core.T) { | |
| subject := (*DenoClient).Ping | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestDenoclient_DenoClient_Ping_Bad(t *core.T) { | |
| subject := (*DenoClient).Ping | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestDenoclient_DenoClient_Ping_Ugly(t *core.T) { | |
| subject := (*DenoClient).Ping | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestDenoclient_DenoClient_LoadModule_Good(t *core.T) { | |
| subject := (*DenoClient).LoadModule | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestDenoclient_DenoClient_LoadModule_Bad(t *core.T) { | |
| subject := (*DenoClient).LoadModule | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestDenoclient_DenoClient_LoadModule_Ugly(t *core.T) { | |
| subject := (*DenoClient).LoadModule | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestDenoclient_DenoClient_UnloadModule_Good(t *core.T) { | |
| subject := (*DenoClient).UnloadModule | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestDenoclient_DenoClient_UnloadModule_Bad(t *core.T) { | |
| subject := (*DenoClient).UnloadModule | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestDenoclient_DenoClient_UnloadModule_Ugly(t *core.T) { | |
| subject := (*DenoClient).UnloadModule | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestDenoclient_DenoClient_ModuleStatus_Good(t *core.T) { | |
| subject := (*DenoClient).ModuleStatus | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestDenoclient_DenoClient_ModuleStatus_Bad(t *core.T) { | |
| subject := (*DenoClient).ModuleStatus | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestDenoclient_DenoClient_ModuleStatus_Ugly(t *core.T) { | |
| subject := (*DenoClient).ModuleStatus | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestDenoclient_DenoClient_ReloadModules_Good(t *core.T) { | |
| subject := (*DenoClient).ReloadModules | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestDenoclient_DenoClient_ReloadModules_Bad(t *core.T) { | |
| subject := (*DenoClient).ReloadModules | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestDenoclient_DenoClient_ReloadModules_Ugly(t *core.T) { | |
| subject := (*DenoClient).ReloadModules | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| import ( | |
| "bufio" | |
| "encoding/json" | |
| "net" | |
| "path/filepath" | |
| core "dappco.re/go/core" | |
| "testing" | |
| "time" | |
| ) |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go/denoclient_test.go` around lines 514 - 743, The new tests (e.g.,
TestDenoclient_DialDeno_Good, TestDenoclient_DenoClient_Close_Good,
TestDenoclient_DenoClient_Ping_Good, etc.) use the type *core.T but the package
import for dappco.re/go/core is missing; add an import for "dappco.re/go/core"
to the file's import block so the *core.T type is defined and the tests compile.
Comment on lines
+252
to
+382
| func TestLifecycle_Sidecar_Start_Good(t *core.T) { | ||
| subject := (*Sidecar).Start | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestLifecycle_Sidecar_Start_Bad(t *core.T) { | ||
| subject := (*Sidecar).Start | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestLifecycle_Sidecar_Start_Ugly(t *core.T) { | ||
| subject := (*Sidecar).Start | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestLifecycle_Sidecar_Stop_Good(t *core.T) { | ||
| subject := (*Sidecar).Stop | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestLifecycle_Sidecar_Stop_Bad(t *core.T) { | ||
| subject := (*Sidecar).Stop | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestLifecycle_Sidecar_Stop_Ugly(t *core.T) { | ||
| subject := (*Sidecar).Stop | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestLifecycle_Sidecar_IsRunning_Good(t *core.T) { | ||
| subject := (*Sidecar).IsRunning | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestLifecycle_Sidecar_IsRunning_Bad(t *core.T) { | ||
| subject := (*Sidecar).IsRunning | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestLifecycle_Sidecar_IsRunning_Ugly(t *core.T) { | ||
| subject := (*Sidecar).IsRunning | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestLifecycle_Sidecar_ExitError_Good(t *core.T) { | ||
| subject := (*Sidecar).ExitError | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestLifecycle_Sidecar_ExitError_Bad(t *core.T) { | ||
| subject := (*Sidecar).ExitError | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestLifecycle_Sidecar_ExitError_Ugly(t *core.T) { | ||
| subject := (*Sidecar).ExitError | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "1) Locate all *core.T usages in go/lifecycle_test.go"
rg -nP --type=go '\*core\.T\)' go/lifecycle_test.go
echo
echo "2) Confirm imports in file header"
sed -n '1,25p' go/lifecycle_test.goRepository: dAppCore/ts
Length of output: 1307
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "1) Search for any definition of type T in a core package"
rg -n 'type T (struct|interface)' --type=go | head -20
echo
echo "2) Search for imports of 'core' package in test files"
rg -n 'import.*core' --type=go
echo
echo "3) Check if core.T is used elsewhere in the codebase"
rg -n '\*core\.T\)' --type=go | wc -l
echo
echo "4) Count total occurrences of *core.T"
rg -c '\*core\.T' --type=go || echo "0"Repository: dAppCore/ts
Length of output: 112
All 12 new lifecycle tests use undefined type *core.T instead of *testing.T.
Lines 252–382 contain test functions using *core.T as the test parameter type, but core is not imported in this file. The file imports "testing" from the standard library, and existing tests in this file correctly use *testing.T. Replace *core.T with *testing.T in all 12 function signatures: TestLifecycle_Sidecar_Start_Good, TestLifecycle_Sidecar_Start_Bad, TestLifecycle_Sidecar_Start_Ugly, TestLifecycle_Sidecar_Stop_Good, TestLifecycle_Sidecar_Stop_Bad, TestLifecycle_Sidecar_Stop_Ugly, TestLifecycle_Sidecar_IsRunning_Good, TestLifecycle_Sidecar_IsRunning_Bad, TestLifecycle_Sidecar_IsRunning_Ugly, TestLifecycle_Sidecar_ExitError_Good, TestLifecycle_Sidecar_ExitError_Bad, and TestLifecycle_Sidecar_ExitError_Ugly.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go/lifecycle_test.go` around lines 252 - 382, The 12 test functions
(TestLifecycle_Sidecar_Start_Good, TestLifecycle_Sidecar_Start_Bad,
TestLifecycle_Sidecar_Start_Ugly, TestLifecycle_Sidecar_Stop_Good,
TestLifecycle_Sidecar_Stop_Bad, TestLifecycle_Sidecar_Stop_Ugly,
TestLifecycle_Sidecar_IsRunning_Good, TestLifecycle_Sidecar_IsRunning_Bad,
TestLifecycle_Sidecar_IsRunning_Ugly, TestLifecycle_Sidecar_ExitError_Good,
TestLifecycle_Sidecar_ExitError_Bad, TestLifecycle_Sidecar_ExitError_Ugly)
incorrectly use the undefined type *core.T; update each function signature to
use *testing.T instead (e.g., change func TestLifecycle_Sidecar_Start_Good(t
*core.T) to func TestLifecycle_Sidecar_Start_Good(t *testing.T)), keeping the
bodies unchanged and relying on the existing "testing" import.
Comment on lines
+120
to
+151
| func TestLocale_Server_LocaleGet_Good(t *core.T) { | ||
| subject := (*Server).LocaleGet | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestLocale_Server_LocaleGet_Bad(t *core.T) { | ||
| subject := (*Server).LocaleGet | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestLocale_Server_LocaleGet_Ugly(t *core.T) { | ||
| subject := (*Server).LocaleGet | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify this file uses *core.T but does not import core.
rg -nP 'func\s+Test\w+\(t\s+\*core\.T\)' go/locale_test.go
rg -nP '^\s*core\s+"dappco\.re/go/core"' go/locale_test.goRepository: dAppCore/ts
Length of output: 219
🏁 Script executed:
head -20 go/locale_test.goRepository: dAppCore/ts
Length of output: 347
core is referenced without an import.
Lines 120, 131, and 142 use *core.T, but go/locale_test.go never imports dappco.re/go/core; these tests will not compile.
🔧 Proposed fix
import (
"context"
"errors"
+ core "dappco.re/go/core"
"testing"
io "dappco.re/go/io"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go/locale_test.go` around lines 120 - 151, The tests reference core.T but the
package isn't imported; update the test file's import block to include the core
package (import "dappco.re/go/core") so the symbol *core.T resolves, ensuring
functions like TestLocale_Server_LocaleGet_Good,
TestLocale_Server_LocaleGet_Bad, and TestLocale_Server_LocaleGet_Ugly compile;
add the import to the existing imports (or create an import block if missing)
and run `go test` to confirm success.
Comment on lines
+62
to
+159
| func TestPermissions_CheckPath_Good(t *core.T) { | ||
| subject := CheckPath | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestPermissions_CheckPath_Bad(t *core.T) { | ||
| subject := CheckPath | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestPermissions_CheckPath_Ugly(t *core.T) { | ||
| subject := CheckPath | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestPermissions_CheckNet_Good(t *core.T) { | ||
| subject := CheckNet | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestPermissions_CheckNet_Bad(t *core.T) { | ||
| subject := CheckNet | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestPermissions_CheckNet_Ugly(t *core.T) { | ||
| subject := CheckNet | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestPermissions_CheckRun_Good(t *core.T) { | ||
| subject := CheckRun | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestPermissions_CheckRun_Bad(t *core.T) { | ||
| subject := CheckRun | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestPermissions_CheckRun_Ugly(t *core.T) { | ||
| subject := CheckRun | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "1) Find all added signatures using *core.T in go/permissions_test.go"
rg -nP --type=go '\*core\.T\)' go/permissions_test.go
echo
echo "2) Show import block to verify whether package core is imported"
sed -n '1,25p' go/permissions_test.goRepository: dAppCore/ts
Length of output: 1281
Replace *core.T with *testing.T to fix test compilation.
Lines 62, 73, 84, 95, 106, 117, 128, 139, and 150 use *core.T, but the core package is not imported in this file. Only the testing package is available. This causes undefined: core at compile time and blocks the file from compiling.
Suggested fix
-func TestPermissions_CheckPath_Good(t *core.T) {
+func TestPermissions_CheckPath_Good(t *testing.T) {
-func TestPermissions_CheckPath_Bad(t *core.T) {
+func TestPermissions_CheckPath_Bad(t *testing.T) {
-func TestPermissions_CheckPath_Ugly(t *core.T) {
+func TestPermissions_CheckPath_Ugly(t *testing.T) {
-func TestPermissions_CheckNet_Good(t *core.T) {
+func TestPermissions_CheckNet_Good(t *testing.T) {
-func TestPermissions_CheckNet_Bad(t *core.T) {
+func TestPermissions_CheckNet_Bad(t *testing.T) {
-func TestPermissions_CheckNet_Ugly(t *core.T) {
+func TestPermissions_CheckNet_Ugly(t *testing.T) {
-func TestPermissions_CheckRun_Good(t *core.T) {
+func TestPermissions_CheckRun_Good(t *testing.T) {
-func TestPermissions_CheckRun_Bad(t *core.T) {
+func TestPermissions_CheckRun_Bad(t *testing.T) {
-func TestPermissions_CheckRun_Ugly(t *core.T) {
+func TestPermissions_CheckRun_Ugly(t *testing.T) {📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| func TestPermissions_CheckPath_Good(t *core.T) { | |
| subject := CheckPath | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestPermissions_CheckPath_Bad(t *core.T) { | |
| subject := CheckPath | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestPermissions_CheckPath_Ugly(t *core.T) { | |
| subject := CheckPath | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestPermissions_CheckNet_Good(t *core.T) { | |
| subject := CheckNet | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestPermissions_CheckNet_Bad(t *core.T) { | |
| subject := CheckNet | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestPermissions_CheckNet_Ugly(t *core.T) { | |
| subject := CheckNet | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestPermissions_CheckRun_Good(t *core.T) { | |
| subject := CheckRun | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestPermissions_CheckRun_Bad(t *core.T) { | |
| subject := CheckRun | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestPermissions_CheckRun_Ugly(t *core.T) { | |
| subject := CheckRun | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestPermissions_CheckPath_Good(t *testing.T) { | |
| subject := CheckPath | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestPermissions_CheckPath_Bad(t *testing.T) { | |
| subject := CheckPath | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestPermissions_CheckPath_Ugly(t *testing.T) { | |
| subject := CheckPath | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestPermissions_CheckNet_Good(t *testing.T) { | |
| subject := CheckNet | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestPermissions_CheckNet_Bad(t *testing.T) { | |
| subject := CheckNet | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestPermissions_CheckNet_Ugly(t *testing.T) { | |
| subject := CheckNet | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestPermissions_CheckRun_Good(t *testing.T) { | |
| subject := CheckRun | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestPermissions_CheckRun_Bad(t *testing.T) { | |
| subject := CheckRun | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestPermissions_CheckRun_Ugly(t *testing.T) { | |
| subject := CheckRun | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go/permissions_test.go` around lines 62 - 159, The tests currently declare
their receiver parameter type as *core.T which is undefined; change all test
function parameters (e.g., TestPermissions_CheckPath_Good,
TestPermissions_CheckPath_Bad, TestPermissions_CheckPath_Ugly,
TestPermissions_CheckNet_Good, TestPermissions_CheckNet_Bad,
TestPermissions_CheckNet_Ugly, TestPermissions_CheckRun_Good,
TestPermissions_CheckRun_Bad, TestPermissions_CheckRun_Ugly) from *core.T to
*testing.T and ensure the testing package is imported at the top of the file so
the file compiles.
Comment on lines
+638
to
+1065
| func TestServer_NewServer_Good(t *core.T) { | ||
| subject := NewServer | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_NewServer_Bad(t *core.T) { | ||
| subject := NewServer | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_NewServer_Ugly(t *core.T) { | ||
| subject := NewServer | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_RegisterModule_Good(t *core.T) { | ||
| subject := (*Server).RegisterModule | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_RegisterModule_Bad(t *core.T) { | ||
| subject := (*Server).RegisterModule | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_RegisterModule_Ugly(t *core.T) { | ||
| subject := (*Server).RegisterModule | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_UnregisterModule_Good(t *core.T) { | ||
| subject := (*Server).UnregisterModule | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_UnregisterModule_Bad(t *core.T) { | ||
| subject := (*Server).UnregisterModule | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_UnregisterModule_Ugly(t *core.T) { | ||
| subject := (*Server).UnregisterModule | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_Ping_Good(t *core.T) { | ||
| subject := (*Server).Ping | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_Ping_Bad(t *core.T) { | ||
| subject := (*Server).Ping | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_Ping_Ugly(t *core.T) { | ||
| subject := (*Server).Ping | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_FileRead_Good(t *core.T) { | ||
| subject := (*Server).FileRead | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_FileRead_Bad(t *core.T) { | ||
| subject := (*Server).FileRead | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_FileRead_Ugly(t *core.T) { | ||
| subject := (*Server).FileRead | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_FileWrite_Good(t *core.T) { | ||
| subject := (*Server).FileWrite | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_FileWrite_Bad(t *core.T) { | ||
| subject := (*Server).FileWrite | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_FileWrite_Ugly(t *core.T) { | ||
| subject := (*Server).FileWrite | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_FileList_Good(t *core.T) { | ||
| subject := (*Server).FileList | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_FileList_Bad(t *core.T) { | ||
| subject := (*Server).FileList | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_FileList_Ugly(t *core.T) { | ||
| subject := (*Server).FileList | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_FileDelete_Good(t *core.T) { | ||
| subject := (*Server).FileDelete | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_FileDelete_Bad(t *core.T) { | ||
| subject := (*Server).FileDelete | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_FileDelete_Ugly(t *core.T) { | ||
| subject := (*Server).FileDelete | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_StoreGet_Good(t *core.T) { | ||
| subject := (*Server).StoreGet | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_StoreGet_Bad(t *core.T) { | ||
| subject := (*Server).StoreGet | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_StoreGet_Ugly(t *core.T) { | ||
| subject := (*Server).StoreGet | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_StoreSet_Good(t *core.T) { | ||
| subject := (*Server).StoreSet | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_StoreSet_Bad(t *core.T) { | ||
| subject := (*Server).StoreSet | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_StoreSet_Ugly(t *core.T) { | ||
| subject := (*Server).StoreSet | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_SetProcessRunner_Good(t *core.T) { | ||
| subject := (*Server).SetProcessRunner | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_SetProcessRunner_Bad(t *core.T) { | ||
| subject := (*Server).SetProcessRunner | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_SetProcessRunner_Ugly(t *core.T) { | ||
| subject := (*Server).SetProcessRunner | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_ProcessStart_Good(t *core.T) { | ||
| subject := (*Server).ProcessStart | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_ProcessStart_Bad(t *core.T) { | ||
| subject := (*Server).ProcessStart | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_ProcessStart_Ugly(t *core.T) { | ||
| subject := (*Server).ProcessStart | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_ProcessStop_Good(t *core.T) { | ||
| subject := (*Server).ProcessStop | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Good" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_ProcessStop_Bad(t *core.T) { | ||
| subject := (*Server).ProcessStop | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Bad" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } | ||
|
|
||
| func TestServer_Server_ProcessStop_Ugly(t *core.T) { | ||
| subject := (*Server).ProcessStop | ||
| if subject == nil { | ||
| t.FailNow() | ||
| } | ||
| marker := "Service:Ugly" | ||
| if marker == "" { | ||
| t.FailNow() | ||
| } | ||
| } |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "1) Count and list *core.T usages in go/server_test.go"
rg -nP --type=go '\*core\.T\)' go/server_test.go
echo
echo "2) Show top import section to confirm available test types"
sed -n '1,30p' go/server_test.goRepository: dAppCore/ts
Length of output: 2921
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "1) Check entire file for 'core' imports or package references"
rg -n 'import.*core|^import \(' go/server_test.go | head -20
echo
echo "2) Search for 'core.T' type definition or alias in the file"
rg -n 'type.*T\s*=' go/server_test.go
echo
echo "3) Get complete import block"
sed -n '1,50p' go/server_test.go | rg -A 50 'import'Repository: dAppCore/ts
Length of output: 189
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Complete import section of go/server_test.go:"
sed -n '1,20p' go/server_test.goRepository: dAppCore/ts
Length of output: 502
Change all test parameter types from *core.T to *testing.T across lines 638–1056.
The file imports testing but not core, causing 36 test functions to fail compilation. All test function signatures using *core.T must be changed to *testing.T.
Example fix
-func TestServer_NewServer_Good(t *core.T) {
+func TestServer_NewServer_Good(t *testing.T) {Apply this change to all 36 test functions in lines 638–1056.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| func TestServer_NewServer_Good(t *core.T) { | |
| subject := NewServer | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_NewServer_Bad(t *core.T) { | |
| subject := NewServer | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_NewServer_Ugly(t *core.T) { | |
| subject := NewServer | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_RegisterModule_Good(t *core.T) { | |
| subject := (*Server).RegisterModule | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_RegisterModule_Bad(t *core.T) { | |
| subject := (*Server).RegisterModule | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_RegisterModule_Ugly(t *core.T) { | |
| subject := (*Server).RegisterModule | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_UnregisterModule_Good(t *core.T) { | |
| subject := (*Server).UnregisterModule | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_UnregisterModule_Bad(t *core.T) { | |
| subject := (*Server).UnregisterModule | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_UnregisterModule_Ugly(t *core.T) { | |
| subject := (*Server).UnregisterModule | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_Ping_Good(t *core.T) { | |
| subject := (*Server).Ping | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_Ping_Bad(t *core.T) { | |
| subject := (*Server).Ping | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_Ping_Ugly(t *core.T) { | |
| subject := (*Server).Ping | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_FileRead_Good(t *core.T) { | |
| subject := (*Server).FileRead | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_FileRead_Bad(t *core.T) { | |
| subject := (*Server).FileRead | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_FileRead_Ugly(t *core.T) { | |
| subject := (*Server).FileRead | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_FileWrite_Good(t *core.T) { | |
| subject := (*Server).FileWrite | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_FileWrite_Bad(t *core.T) { | |
| subject := (*Server).FileWrite | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_FileWrite_Ugly(t *core.T) { | |
| subject := (*Server).FileWrite | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_FileList_Good(t *core.T) { | |
| subject := (*Server).FileList | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_FileList_Bad(t *core.T) { | |
| subject := (*Server).FileList | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_FileList_Ugly(t *core.T) { | |
| subject := (*Server).FileList | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_FileDelete_Good(t *core.T) { | |
| subject := (*Server).FileDelete | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_FileDelete_Bad(t *core.T) { | |
| subject := (*Server).FileDelete | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_FileDelete_Ugly(t *core.T) { | |
| subject := (*Server).FileDelete | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_StoreGet_Good(t *core.T) { | |
| subject := (*Server).StoreGet | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_StoreGet_Bad(t *core.T) { | |
| subject := (*Server).StoreGet | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_StoreGet_Ugly(t *core.T) { | |
| subject := (*Server).StoreGet | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_StoreSet_Good(t *core.T) { | |
| subject := (*Server).StoreSet | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_StoreSet_Bad(t *core.T) { | |
| subject := (*Server).StoreSet | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_StoreSet_Ugly(t *core.T) { | |
| subject := (*Server).StoreSet | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_SetProcessRunner_Good(t *core.T) { | |
| subject := (*Server).SetProcessRunner | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_SetProcessRunner_Bad(t *core.T) { | |
| subject := (*Server).SetProcessRunner | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_SetProcessRunner_Ugly(t *core.T) { | |
| subject := (*Server).SetProcessRunner | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_ProcessStart_Good(t *core.T) { | |
| subject := (*Server).ProcessStart | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_ProcessStart_Bad(t *core.T) { | |
| subject := (*Server).ProcessStart | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_ProcessStart_Ugly(t *core.T) { | |
| subject := (*Server).ProcessStart | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_ProcessStop_Good(t *core.T) { | |
| subject := (*Server).ProcessStop | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_ProcessStop_Bad(t *core.T) { | |
| subject := (*Server).ProcessStop | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_ProcessStop_Ugly(t *core.T) { | |
| subject := (*Server).ProcessStop | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_NewServer_Good(t *testing.T) { | |
| subject := NewServer | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_NewServer_Bad(t *testing.T) { | |
| subject := NewServer | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_NewServer_Ugly(t *testing.T) { | |
| subject := NewServer | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_RegisterModule_Good(t *testing.T) { | |
| subject := (*Server).RegisterModule | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_RegisterModule_Bad(t *testing.T) { | |
| subject := (*Server).RegisterModule | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_RegisterModule_Ugly(t *testing.T) { | |
| subject := (*Server).RegisterModule | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_UnregisterModule_Good(t *testing.T) { | |
| subject := (*Server).UnregisterModule | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_UnregisterModule_Bad(t *testing.T) { | |
| subject := (*Server).UnregisterModule | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_UnregisterModule_Ugly(t *testing.T) { | |
| subject := (*Server).UnregisterModule | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_Ping_Good(t *testing.T) { | |
| subject := (*Server).Ping | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_Ping_Bad(t *testing.T) { | |
| subject := (*Server).Ping | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_Ping_Ugly(t *testing.T) { | |
| subject := (*Server).Ping | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_FileRead_Good(t *testing.T) { | |
| subject := (*Server).FileRead | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_FileRead_Bad(t *testing.T) { | |
| subject := (*Server).FileRead | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_FileRead_Ugly(t *testing.T) { | |
| subject := (*Server).FileRead | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_FileWrite_Good(t *testing.T) { | |
| subject := (*Server).FileWrite | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_FileWrite_Bad(t *testing.T) { | |
| subject := (*Server).FileWrite | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_FileWrite_Ugly(t *testing.T) { | |
| subject := (*Server).FileWrite | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_FileList_Good(t *testing.T) { | |
| subject := (*Server).FileList | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_FileList_Bad(t *testing.T) { | |
| subject := (*Server).FileList | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_FileList_Ugly(t *testing.T) { | |
| subject := (*Server).FileList | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_FileDelete_Good(t *testing.T) { | |
| subject := (*Server).FileDelete | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_FileDelete_Bad(t *testing.T) { | |
| subject := (*Server).FileDelete | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_FileDelete_Ugly(t *testing.T) { | |
| subject := (*Server).FileDelete | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_StoreGet_Good(t *testing.T) { | |
| subject := (*Server).StoreGet | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_StoreGet_Bad(t *testing.T) { | |
| subject := (*Server).StoreGet | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_StoreGet_Ugly(t *testing.T) { | |
| subject := (*Server).StoreGet | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_StoreSet_Good(t *testing.T) { | |
| subject := (*Server).StoreSet | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_StoreSet_Bad(t *testing.T) { | |
| subject := (*Server).StoreSet | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_StoreSet_Ugly(t *testing.T) { | |
| subject := (*Server).StoreSet | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_SetProcessRunner_Good(t *testing.T) { | |
| subject := (*Server).SetProcessRunner | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_SetProcessRunner_Bad(t *testing.T) { | |
| subject := (*Server).SetProcessRunner | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_SetProcessRunner_Ugly(t *testing.T) { | |
| subject := (*Server).SetProcessRunner | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_ProcessStart_Good(t *testing.T) { | |
| subject := (*Server).ProcessStart | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_ProcessStart_Bad(t *testing.T) { | |
| subject := (*Server).ProcessStart | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_ProcessStart_Ugly(t *testing.T) { | |
| subject := (*Server).ProcessStart | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_ProcessStop_Good(t *testing.T) { | |
| subject := (*Server).ProcessStop | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Good" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_ProcessStop_Bad(t *testing.T) { | |
| subject := (*Server).ProcessStop | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Bad" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } | |
| func TestServer_Server_ProcessStop_Ugly(t *testing.T) { | |
| subject := (*Server).ProcessStop | |
| if subject == nil { | |
| t.FailNow() | |
| } | |
| marker := "Service:Ugly" | |
| if marker == "" { | |
| t.FailNow() | |
| } | |
| } |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go/server_test.go` around lines 638 - 1065, Change the receiver parameter
type for all test functions currently declared with *core.T to *testing.T; e.g.,
update signatures for TestServer_NewServer_Good/Bad/Ugly, the
TestServer_Server_RegisterModule_*/UnregisterModule_*/Ping_*/FileRead_*/FileWrite_*/FileList_*/FileDelete_*/StoreGet_*/StoreSet_*/SetProcessRunner_*/ProcessStart_*/ProcessStop_*
functions so each takes (*testing.T) instead of (*core.T), ensuring the import
remains testing and removing references to core in those signatures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: core/api/LICENCE.
Summary by CodeRabbit
Documentation
Chores
Tests