Skip to content

Api key too long - invalid#34

Open
ivangrozni wants to merge 2 commits into
d8-contrib-modules:masterfrom
ivangrozni:master
Open

Api key too long - invalid#34
ivangrozni wants to merge 2 commits into
d8-contrib-modules:masterfrom
ivangrozni:master

Conversation

@ivangrozni

Copy link
Copy Markdown

Small improvement off this PR #33
Which addresses this issue https://www.drupal.org/project/cloudflare/issues/3149855

@froboy

froboy commented May 4, 2021

Copy link
Copy Markdown

I think doing our own checks on the validity of this token are going to result in problems. As per https://api.cloudflare.com/#user-api-tokens-verify-token it looks like tokens could have - or _ as well. Instead of doing our own validation, could we make a call to GET user/tokens/verify to have Cloudflare verify the token?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants