This repository was archived by the owner on May 22, 2026. It is now read-only.
Execute all handlers for each lifecycle phase concurrently#22
Open
krystsinaetc wants to merge 4 commits into
Open
Execute all handlers for each lifecycle phase concurrently#22krystsinaetc wants to merge 4 commits into
krystsinaetc wants to merge 4 commits into
Conversation
krystsinaetc
force-pushed
the
concurrent_handlers
branch
from
October 9, 2017 09:52
01272b8 to
6e2d720
Compare
krystsinaetc
force-pushed
the
concurrent_handlers
branch
from
October 9, 2017 09:55
6e2d720 to
0814380
Compare
Contributor
|
@toddschilling - Will this break any current use cases? If so we may need to version up. |
Contributor
|
@euforia I guess it depends. In the case of nats events, the sequence of the events for a given unit of work are important. Does this create the potential for sending a progress event AFTER a success or fail event? If so, that will probably cause problems with event consumers. |
Contributor
|
As long as the lifecycle sequence is honored i think that we're ok. |
toddschilling
approved these changes
Nov 2, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#17