Fix Windows shell shutdown and path handling - #1
Merged
Conversation
d0lb33
marked this pull request as ready for review
August 4, 2026 17:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The npm launcher used a relay process, so Git Bash could return to the prompt while the actual WorkTrellis shutdown was still running. At the same time, Portless 0.15.x joins command arguments into an unquoted
cmd.exestring and exits immediately from its signal handler, which could both truncateC:\\Program Files\\...paths and leave the underlying Next.js tree alive.Impact
One Ctrl+C now remains owned by the foreground WorkTrellis supervisor, and Windows process-tree cleanup can discover and reap a listener even when persisted run state is missing. Standard Node installations under
C:\\Program Filesalso launch correctly through Portless.Validation
pnpm install --frozen-lockfilepnpm typecheckpnpm testpnpm buildnode bin/worktrellis.mjs --versionnode bin/worktrellis.mjs self-checknpm pack --dry-rungit diff --check