Skip to content

Made some refactoring, fixed some potential issues#8

Open
edwardt wants to merge 23 commits into
cweidenkeller:masterfrom
edwardt:master
Open

Made some refactoring, fixed some potential issues#8
edwardt wants to merge 23 commits into
cweidenkeller:masterfrom
edwardt:master

Conversation

@edwardt

@edwardt edwardt commented Jul 11, 2012

Copy link
Copy Markdown

Hi,

Made some refactoring summary:

  • Break up client.cs into individual logical entities
  • promote some common code/behavior in responses to base class
  • made abstract class on client to interface since no behavior inheritance
  • put check keys before adding to dictionary or else exception will occur
  • grouping files into separate folders in solutions
  • close response stream on GetObject
  • rename some classes name to reflect intentions.
  • add a custom constructor on client to allow configurable timeout and chucksize

@edwardt

edwardt commented Jul 11, 2012

Copy link
Copy Markdown
Author

The first 12 checkins had poor comments .. at that point I didn't intend for a merge up but just checking out the code.
not sure how to edit those comment outs .......... but the code changes are not that junk

@edwardt

edwardt commented Jul 16, 2012

Copy link
Copy Markdown
Author

use stash to clean up the "in-between" comments.
put a branch instead of master for this pull request
may be add more info on readme for this dll

@cweidenkeller

Copy link
Copy Markdown
Owner

Looks good to me. Was that last comment for me to do or have you already done it?

Thanks!

@edwardt

edwardt commented Jul 23, 2012

Copy link
Copy Markdown
Author

No more changes. I should have given u a branch instead of the master .. and squash the extra comments.
please do the up merge. Anywork I am going forward will be on a seperate branch.
BTW, have you tested this api against auth.api.rackspacecloud.com/v1.0/ ??????

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants