Bugfixes#120
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bufixes
argmin→argmaxwhen selecting best layer incompare_modelp < 0.5→p < 0.05incompare_modelenumerate()inevaluate()loop overself.model_rdmscheck_squareformcalled on a list instead of the numpy array inside itr_lstfrom last loop iteration instead of current layer/ROI correlationstrain_Ridgeregression_per_ROIsaves unfittedreginstead ofbest_modelwhensave_model=Truep > nvsp <= nconditional infeat_ridge_CVevaluate_4missing triple-shared variance keys (y123, y124, y134, y234)evaluate_4description labels bugix