clarify build instructions for windows - #28
Open
mbaas2 wants to merge 5 commits into
Open
Conversation
…version+edition+bits spec The "did not start on port" error now names the binary that was launched, since PATH can silently resolve to an ancient Dyalog install (e.g. 14.1, which predates RIDE protocol v2) instead of the intended discovered version. -version also accepts a compact "210U64" form (version, C/U edition, 32/64 bits) on Windows, letting Classic builds and a specific bitness be selected explicitly. Plain "X.Y" strings keep their exact prior behaviour (Unicode-only, no bits filter).
kill_wait_test.go used syscall.Setpgid/syscall.Kill unconditionally, which don't exist on Windows and broke `go test ./...` for the whole package. Split it: platform-neutral tests (rendering, config parsing, nil-cmd paths) stay in kill_wait_test.go; the tests that spawn SIGTERM-ignoring Unix processes via sh/trap/process-groups move to a new kill_wait_unix_test.go under //go:build !windows, matching the existing proc_unix.go/proc_windows.go split in this package. TestDyalogEnv also hardcoded a Unix-style expected path, which filepath.Dir renders with backslashes on Windows — fixed by deriving the expected value from filepath.Dir/Join instead of a literal string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.