fix: Open Library general q search so translated titles match#8
Merged
Conversation
Books search used `title=`, which only matches a work's primary (usually English) title — so "Policán 3" (the Spanish title of Dog Man) returned nothing. Switch to the general `q=` parameter, which matches across all fields incl. edition/translated titles and still ranks title hits first. Verified identical quality for dune / harry potter and now finds Dog Man for "Policán". Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Searching "Policán 3" (the Spanish title of Dav Pilkey's Dog Man) returned no book, even though Open Library has it at
/works/OL17798838W.Our books provider queried
title=, which only matches a work's primary (usually English) title — so the Spanish edition title never matched.Fix
Switch the Open Library call from
title=to the generalq=parameter.qmatches across all fields (incl. translated/edition titles) and still ranks title hits first.Verified against the live Open Library API:
q=Policán→ Dog Man (the expected work) ✅q=dune/q=harry potter→ identical top results to before ✅🤖 Generated with Claude Code