fix: make /search public to stop spurious 401s#7
Merged
Conversation
The item-name typeahead fires on every keystroke and was hitting the auth-guarded /search route with the cached Google ID token, which is short-lived (~1h) and not refreshed — so once it expired, search 401'd. External-catalog search (Open Library / TMDB / iTunes) exposes no private data and the TMDB key stays server-side regardless, so authentication added no protection here — only failure modes. Drop the auth middleware from the /search group. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The new item-name typeahead fires
GET /search/?q=on every keystroke. The route was auth-guarded, so it sent the cached Google ID token — which is short-lived (~1h) and not auto-refreshed. Once expired, every search returned401 Unauthorized(as seen in the browser console hittingapi.curatedli.st/search/).Fix
Make
/search/public. External-catalog search (Open Library / TMDB / iTunes) exposes no private data, and the TMDB API key stays server-side regardless — so the auth middleware added no real protection here, only failure modes. This is a one-line route change (dropTokenAuthMiddlewarefrom the/searchgroup); list/user routes stay guarded.🤖 Generated with Claude Code