feat: show localized (matched-edition) book titles#10
Merged
Conversation
Searching in Spanish returned English work titles — "Policán 3" showed as "Dog Man". Open Library's search `editions` field returns the specific edition that matched the query, so request it and prefer that edition's title and cover over the work's primary (English) ones. The work URL is kept for the lazy description fetch. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Searching in Spanish returned English titles — "Policán 3" showed up as "Dog Man" (the work's primary/English title).
Fix
Open Library's search
editionsfield returns the specific edition that matched the query. Request it (fields=…,editions) and prefer that edition's title and cover over the work's primary ones. So a Spanish query surfaces the Spanish title and Spanish cover; an English query still gets the English edition. Falls back to the work title/cover when no edition is returned. Work URL is unchanged, so the lazy/search/bookdescription fetch still resolves.🤖 Generated with Claude Code