fix: stop stale page_type from permanently killing event collection - #578
Merged
Conversation
The COALESCE in renderPage.js preserved old page_type classifications forever, even after re-rendering fresh content. Event listing pages misclassified as 'neither' could never self-heal, silently killing event collection for 7 of 16 sources (some since May 2026). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tp5oiFXGQ9M4wTzTJBCQds
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COALESCEfrom renderPage.js that preserved stalepage_typeclassifications foreverpage_typenow resets to NULL, forcing the AI classifier to re-evaluateneither(some since May 2026)Context
Event collection has been returning 0 events since Aug 3. Root cause: the
COALESCE(EXCLUDED.page_type, rendered_page_cache.page_type)on line 57 meant that once a listing page was classified asneither, it stayedneitherforever — even after re-rendering fresh content. The classifier never got a chance to re-evaluate becausenewsService.jsskips classification whenpageTypeis already set.Test plan
events_found > 0🤖 Generated with Claude Code
https://claude.ai/code/session_01Tp5oiFXGQ9M4wTzTJBCQds