Fix missing md-lite dependency and Sanity template instructions#172
Merged
Conversation
Several templates ship a markdown.tsx utility importing @croct/md-lite without declaring it as a dependency, so fresh installs fail with "Module not found". It only worked when an ancestor node_modules happened to contain the package. Also replace the Sanity template's example launcher with explicit instructions, since the Sanity CLI cannot be launched from the template and dev servers may bind to dynamic ports. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@croct/md-litedependency to all templates that install amarkdown.tsxutility importing it:croct/integration/sanity,croct/ui/component/announcement-bar,hero-ui/component/cookie-consent,material-ui/block/faq-section,material-ui/block/hero-section, andmaterial-ui/template/marketing-page. Fresh installs of these templates failed withModule not found: Can't resolve '@croct/md-lite'— no published Croct package pulls it in transitively, so it only resolved by accident when an ancestornode_modulescontained it (the mantine templates already declare it correctly).example-launcherimport with an explicit success message telling the user to runcd <project> && npm run dev, since the Sanity CLI cannot be launched from the template. The message points to the command output for URLs instead of hardcoding them, as ports may be assigned dynamically.Test plan
template.json5files validate as JSON5croct use croct://integration/sanityin an empty directory and confirm@croct/md-litelands infrontend/package.jsonandnpm run devcompiles🤖 Generated with Claude Code