ci: build and test pull requests - #51
Merged
Merged
Conversation
The repo had no CI workflow — only release.yml — so nothing built or tested master or any pull request. That is how master reached a state where Gradle could not configure the project at all: AGP 9.3.1 landed by Dependabot while app/build.gradle.kts still declared org.jetbrains.kotlin.android, which AGP 9 rejects outright. Gates ktlintCheck, unit tests, assembleDebug and assembleRelease, each as its own invocation so a failure names the gate that broke. assembleRelease is included because R8/minify and lintVitalRelease are the parts of the release build most likely to break unnoticed until release day. Pinned to ubuntu-24.04 and Temurin 17 to match release.yml, so a green run means the same toolchain the release is built with. The full lint task is deliberately not gated: it reports 151 errors today, 143 of them MissingTranslation from the zh-rCN translation being 72 of 217 strings complete. Gating on that would mean permanently red CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repo had no CI workflow — only
release.yml. Nothing built or tested master or any pull request.That is not hypothetical: it is how master reached a state where Gradle could not configure the project at all. Dependabot landed AGP 9.3.1 in #47 while
app/build.gradle.ktsstill declaredorg.jetbrains.kotlin.android, which AGP 9 rejects outright:Every Dependabot PR since has merged green on a repo where
./gradlewcould not run.Gates
:app:ktlintCheckignoreFailures = false, but nothing ran it:app:testDebugUnitTest:app:assembleDebug:app:assembleReleaselintVitalRelease— the parts most likely to break unnoticed until release dayEach is its own invocation so a red run names the gate that broke rather than one opaque "build failed". The Gradle daemon is reused across steps, so the extra invocations cost very little.
Pinned to
ubuntu-24.04and Temurin 17 to matchrelease.yml, so a green CI run means the same toolchain the release is actually built with.concurrencycancels superseded runs on the same ref.All four gates verified green locally on master before being added.
The full
linttask is deliberately not gatedIt fails today with 151 errors:
MissingTranslationLocalContextGetResourceValueCallModifierParameterAutoboxingStateCreationThe
MissingTranslationmass is entirelyvalues-zh-rCN, which has 72 of the 217 strings invalues. Gating on that would mean permanently red CI, soassembleRelease'slintVitalReleasecovers the fatal-severity checks instead.Worth addressing separately, and they split cleanly: the 10 non-translation findings look like real Compose issues worth fixing, while the translation gap wants either a completed
zh-rCNorlint { disable += "MissingTranslation" }. Happy to take either on.