Skip to content

Add hasSchemaFormConfig to Sentry client payload and update related… - #571

Merged
crimsonstrife merged 1 commit into
prodfrom
dev
Jun 2, 2026
Merged

Add hasSchemaFormConfig to Sentry client payload and update related…#571
crimsonstrife merged 1 commit into
prodfrom
dev

Conversation

@crimsonstrife

@crimsonstrife crimsonstrife commented Jun 2, 2026

Copy link
Copy Markdown
Owner

… test assertions

Summary by Sourcery

Include the hasSchemaFormConfig flag in Sentry issue alert rule payloads and update tests to assert its presence.

New Features:

  • Add hasSchemaFormConfig flag to Sentry issue alert rule action payloads sent to Sentry.

Tests:

  • Adjust Sentry outbound sync tests to expect the hasSchemaFormConfig flag in the action payload.

@crimsonstrife crimsonstrife self-assigned this Jun 2, 2026
Copilot AI review requested due to automatic review settings June 2, 2026 17:38
@sourcery-ai

sourcery-ai Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the Sentry client’s issue alert rule payload to explicitly send a hasSchemaFormConfig flag and aligns the feature test expectations with this new contract.

Sequence diagram for Sentry issue alert rule creation including hasSchemaFormConfig

sequenceDiagram
    participant App as App
    participant SentryClient as SentryClient
    participant SentryAPI as SentryAPI

    App->>SentryClient: createIssueAlertRule(projectSlug, priorityId)
    SentryClient->>SentryAPI: POST /projects/{projectSlug}/alerts/rules
    activate SentryAPI
    Note over SentryClient,SentryAPI: Payload.customSettings includes hasSchemaFormConfig = true
    SentryAPI-->>SentryClient: 201 Created
    SentryClient-->>App: Issue alert rule created response
Loading

File-Level Changes

Change Details Files
Include hasSchemaFormConfig flag in the Sentry issue alert rule action payload and update the corresponding feature test expectation.
  • Add hasSchemaFormConfig => true to the Sentry notify_event_sentry_app action payload when creating issue alert rules.
  • Adjust the Sentry outbound sync feature test to assert that hasSchemaFormConfig is present and true instead of absent from the action payload.
app/Integrations/Sentry/Services/SentryClient.php
tests/Feature/Integrations/Sentry/OutboundSyncTest.php

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@crimsonstrife

Copy link
Copy Markdown
Owner Author

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@crimsonstrife
crimsonstrife merged commit 2ddccae into prod Jun 2, 2026
9 of 12 checks passed
@deepsource-io

deepsource-io Bot commented Jun 2, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 69d0a37...5e38d80 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Jun 2, 2026 5:38p.m. Review ↗
JavaScript Jun 2, 2026 5:38p.m. Review ↗
Python Jun 2, 2026 5:38p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Sentry issue alert rule creation payload to include a hasSchemaFormConfig flag, and adjusts the outbound sync feature test to assert that the flag is present and set to true.

Changes:

  • Add hasSchemaFormConfig: true to the Sentry action payload when creating issue alert rules.
  • Update the outbound sync feature test to assert hasSchemaFormConfig is included and true.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
app/Integrations/Sentry/Services/SentryClient.php Adds hasSchemaFormConfig to the Sentry issue alert rule action payload.
tests/Feature/Integrations/Sentry/OutboundSyncTest.php Updates assertions to expect hasSchemaFormConfig === true in the outbound request payload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants