Remove unused hasSchemaFormConfig and update Sentry schema with new… - #570
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves the no-longer-used hasSchemaFormConfig flag from Sentry app alert actions and updates the Sentry integration schema to reflect the new webhook URI/settings, aligning tests, client payload, and schema JSON with Sentry’s latest expectations. Sequence diagram for SentryClient createIssueAlertRule payload without hasSchemaFormConfigsequenceDiagram
participant App
participant SentryClient
participant SentryAPI
App->>SentryClient: createIssueAlertRule(projectId, priorityId, webhookUri)
SentryClient->>SentryAPI: POST /projects/{projectId}/alerts/rules
activate SentryAPI
SentryAPI-->>SentryClient: 201 Created
deactivate SentryAPI
SentryClient-->>App: createIssueAlertRule response
%% Core payload fields changed in this PR (no hasSchemaFormConfig)
%% Represented as part of the HTTP call label above:
%% body.actions[0].sentryAppInstallationUuid
%% body.actions[0].settings[0].name = forge_priority_id
%% body.actions[0].settings[1].name = webhook_uri
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| PHP | Jun 2, 2026 5:34p.m. | Review ↗ | |
| JavaScript | Jun 2, 2026 5:34p.m. | Review ↗ | |
| Python | Jun 2, 2026 5:34p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider adding a short code comment or commit message note explaining why
hasSchemaFormConfigmust now be omitted (e.g., Sentry API change), so future maintainers understand that this is intentional and not an accidental removal.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding a short code comment or commit message note explaining why `hasSchemaFormConfig` must now be omitted (e.g., Sentry API change), so future maintainers understand that this is intentional and not an accidental removal.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated hasSchemaFormConfig flag from the Sentry issue alert rule action payload and updates the Sentry integration UI schema to point alert actions at the Sentry webhook endpoint used by this app.
Changes:
- Stop sending
hasSchemaFormConfiginSentryClient::createIssueAlertRule()action payloads. - Update the Sentry integration
schema.jsonto include the alert-rule-actionuripointing to/api/webhooks/sentry. - Update the outbound sync feature test to assert the deprecated field is absent.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/Feature/Integrations/Sentry/OutboundSyncTest.php | Updates assertions to ensure hasSchemaFormConfig is no longer sent in the rule action payload. |
| resources/integrations/sentry/schema.json | Adds the uri for the alert-rule-action to target the Sentry webhook endpoint. |
| app/Integrations/Sentry/Services/SentryClient.php | Removes the deprecated hasSchemaFormConfig field from the action payload sent to Sentry. |
… webhook URI
Summary by Sourcery
Remove deprecated Sentry issue alert action field and update Sentry integration schema.
Enhancements:
Tests: