fix: keep stub log server errors out of HTTP responses in attest test#529
Merged
Conversation
Closes the js/stack-trace-exposure code-scanning alert: the loopback test stub echoed caught error messages into 400 bodies. The diagnostic now goes to the test process stderr and the response carries a static string.
creatornader
enabled auto-merge (squash)
July 16, 2026 02:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the open code-scanning alert (js/stack-trace-exposure, medium) at services/atrib-attest/test/integration.test.ts:58: the in-test loopback log-server stub echoed caught error messages into its 400 response body. The diagnostic now logs to the test process stderr and the wire response carries a static
invalid entrystring. @atrib/attest suite green (157 tests; one known emit-family flake on first run, clean on rerun).