[codex] Tighten REST retries and exchange factory#19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RestClientConfig::max_retriesfor retryable GET/DELETE failures while intentionally avoiding automatic POST retries for order-style side effects.ExchangeFactory.Why
The architecture audit found two concrete issues: retry configuration was documented but not applied, and
ExchangeFactorybypassed builder behavior for Bybit while omitting the newly merged OKX connector.Validation
cargo test core::kernel::rest::tests --all-features -- --nocapturecargo test utils::exchange_factory::tests --all-features -- --nocapturecargo test --test binance_integration_tests binance_comprehensive_tests::test_error_handling_with_bad_credentials --all-features -- --nocapturecargo clippy --all-targets --all-features -- -D warningscargo test --all-featuresReview Notes
A pre-PR read-only review found invalid mock
Content-Lengthvalues in the new REST tests. The tests now deriveContent-Lengthfrom the response body so they exercise the HTTP 500 mapping path directly.