[8649] Fix incorrect MIME type labels for application/javascript and text/texmacs in de.json translations#4897
[8649] Fix incorrect MIME type labels for application/javascript and text/texmacs in de.json translations#4897jvega190 wants to merge 2 commits into
Conversation
…d Korean files; add TypeScript mime type definition.
WalkthroughFixes mislabeled MIME type translation entries for ChangesMIME Type Label Corrections
Authentication Flow Improvements
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related issues
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ui/app/src/utils/mimeTypes.ts`:
- Around line 96-98: The defaultMessage for the 'application/typescript' MIME
type entry uses incorrect capitalization. Locate the mimeTypes object where
'application/typescript' is defined and update its defaultMessage value from
'Typescript' to 'TypeScript' to match the canonical spelling with a capital S.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 57870121-db7a-485a-9ff0-e699c0102e77
📒 Files selected for processing (4)
ui/app/src/translations/de.jsonui/app/src/translations/es.jsonui/app/src/translations/ko.jsonui/app/src/utils/mimeTypes.ts
|
@coderabbitai can you check if everything looks good? Please give it a final review before I hand over for human review |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
echo "=== mimeTypes.ts ==="
cat ui/app/src/utils/mimeTypes.ts
echo ""
echo "=== de.json - mimeTypes section ==="
python3 -c "
import json
with open('ui/app/src/translations/de.json') as f:
data = json.load(f)
mime = {k: v for k, v in data.items() if k.startswith('mimeTypes')}
for k, v in sorted(mime.items()):
print(f'{k}: {v}')
"
echo ""
echo "=== es.json - mimeTypes section ==="
python3 -c "
import json
with open('ui/app/src/translations/es.json') as f:
data = json.load(f)
mime = {k: v for k, v in data.items() if k.startswith('mimeTypes')}
for k, v in sorted(mime.items()):
print(f'{k}: {v}')
"
echo ""
echo "=== ko.json - mimeTypes section ==="
python3 -c "
import json
with open('ui/app/src/translations/ko.json') as f:
data = json.load(f)
mime = {k: v for k, v in data.items() if k.startswith('mimeTypes')}
for k, v in sorted(mime.items()):
print(f'{k}: {v}')
"
echo ""
echo "=== Check for all translation files ==="
fd -e json . ui/app/src/translations/
echo ""
echo "=== Compare mimeTypes keys across all translation files ==="
python3 -c "
import json, os, glob
files = sorted(glob.glob('ui/app/src/translations/*.json'))
all_data = {}
for f in files:
lang = os.path.basename(f)
with open(f) as fh:
data = json.load(fh)
mime = {k: v for k, v in data.items() if k.startswith('mimeTypes')}
all_data[lang] = mime
# Print mimeTypes keys for each language
for lang, mime in all_data.items():
print(f'--- {lang} ---')
for k, v in sorted(mime.items()):
print(f' {k}: {v}')
print()
"Length of output: 22253
✅ Core FixAll three translation files (
✅ mimeTypes.ts
✅ ConsistencyAll three locale files have identical, consistent key sets with no stray entries or mismatches. 📝 Minor Note (non-blocking)The new The PR is ready to hand off for human review! 🐇 |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ui/app/src/components/AuthMonitor/AuthMonitor.tsx`:
- Line 48: The default message for authMonitor.incorrectPasswordMessage in
AuthMonitor.tsx has been updated to "Incorrect username or password. Please try
again.", but the localized translation files (such as de.json and other locale
files in ui/app/src/translations/) still contain the old wording "Incorrect
password...". Update all locale entries for the
authMonitor.incorrectPasswordMessage key across all translation files to match
the new default message so that non-English users see the updated copy.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4d469b7b-948b-4b0a-9440-c9b4f32ec3a5
📒 Files selected for processing (5)
ui/app/src/components/AuthMonitor/AuthMonitor.tsxui/app/src/services/auth.tsui/app/src/state/epics/auth.tsui/app/src/state/reducers/auth.tsui/app/src/utils/mimeTypes.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- ui/app/src/utils/mimeTypes.ts
jvega190
force-pushed
the
enhancement/8649
branch
from
3a8cd9b to
81151c1
Compare
1 participant
craftercms/craftercms#8649
Summary by CodeRabbit