Dependabot/npm and yarn/develop/all UI deps eacba4f3c2#4823
Conversation
…vitejs/plugin-react, @swc/core, @swc/cli
…pat, @eslint/eslintrc, babel-plugin-formatjs, eslint-plugin-react-refresh, css-loader, @eslint/eslintrc, @rollup/plugin-commonjs, @prettier/plugin-xml
…globals, rollup, preact
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 18 minutes and 41 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (78)
WalkthroughMultiple package.json manifests across the repo have dependency/devDependency version bumps; one code change updates a predicate in Changes
Sequence Diagram(s)(omitted — changes are dependency/version updates plus a localized predicate adjustment that does not introduce a new multi-component sequential flow) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@ui/uppy/package.json`:
- Line 54: Remove the eslintConfig field from package.json (the "eslintConfig"
object currently containing parserOptions.sourceType) because ESLint v10 no
longer supports package.json configs; delete that key and rely on the root flat
config or add a dedicated flat config file (eslint.config.mjs) if this package
needs local overrides; ensure no other tooling expects the removed field and
update any project-level documentation or scripts that referenced
"eslintConfig".
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c387e362-9dd2-469b-a2e2-925a189f6e72
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (7)
package.jsonui/app/package.jsonui/app/src/components/FormsEngine/lib/valueRetrievers.tsui/guest/package.jsonui/legacy/package.jsonui/npm-content/package.jsonui/uppy/package.json
…o dependabot/npm_and_yarn/develop/all-ui-deps-eacba4f3c2 # Conflicts: # ui/app/src/components/FormsEngine/lib/valueRetrievers.ts
…stable_config_lookup_from_file flag from root package.json
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@ui/uppy/package.json`:
- Line 54: Add a flat-config override in the ESLint config (eslint.config.mjs)
that targets the Uppy source files by adding an override entry with files:
['ui/uppy/src/**/*.{ts,tsx}'] and parserOptions.sourceType: 'module' (i.e.,
sourceType: 'module') so ESM imports/exports parse correctly; insert this new
override before the existing global TS/TSX override block referenced around
eslint.config.mjs:88 to ensure it takes precedence for ui/uppy files.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a7a26dc5-862b-4da6-91ad-ebeed5b94db7
📒 Files selected for processing (2)
package.jsonui/uppy/package.json
* [7418] Label control * [7418] Standardize fallback handling * [7418] Add dompurify sanitization when setting inner html * [7418] Remove defaultValue * [7418] use getPropertyValue in Label control * [7418] Remove renderAsHTML property from label descriptor, use minimal setup of tinymce in text field * [7418] Add RTE wrapper for TypeBuilder, update label control to use rte for text field, with `craftercms-label-control`. Update RichTextEditor control to support defaultInitOptions prop * [7418] Add dompurify * [7418] Add dompurify * [7418] fix package.json format * [7418] Add dompurify
* [7418] Checkbox readonly and defaultValue updates * [7418] Improve Checkbox readonly value extraction * [7418] Remove retrieving logic from checkbox control, update retrieveFieldValue to omit empty strings as defaultValue * [7418] Update checkbox validator, fix retrieveFieldValue fieldValue calculation * [7418] Update booleanFieldExtractor to return false if nullish value
…ew DataSource type instead of legacy. (craftercms#4806) * [8216] Update dropTargetsLookup in parseLegacyFormDefinition to use new DataSource type instead of legacy * [8216] Fix NodeSelector create component * [8216] Remove unnecessary cast
…ested the publish (craftercms#4831) * [8444] Approver user listed in Dashboard is always the user that requested the publish * [8444] Fix approver for requests in RecentlyPublishedDashlet
…bal configs are unset (craftercms#4797) * Fix error handling in EditTypeView to ensure proper message display, add type to error
* Update field validation logic * Enhance listDirection parsing * Guard placeholder items during filtering * Validate window in useWindowWidth * Parse minSize safely * Update validator to consider empty (or non-array) values * Simplify validateFieldValue logic * Remove unused/duplicate util * Remove unused import * Move utils to bottom of component * Update CheckboxGroup to render a max of 2 columns, and remove rendering of 3 columns logic * Move checkboxGroup validator to fn * Add skeleton for loading state, use props utils * Fix property for selectAll * Update indeterminate and checked conditions of selectAll checkbox to consider filtering * Update checkboxGroupValidator currentValue type * Return undefined for finalOptions nullish options
…ftercms#4808) * Workflow states options should only display valid options * Add error handling on fetchPublishingTargets
…orrupts form (craftercms#4838) * [7511] cleanupStaleDatasourceValues * [7511] Cleanup datasource values from xml * [7511] Remove comment * [7511] Update selector in EditTypeView to use :scope for value element * [7511] consider parse errors --------- Co-authored-by: git_repo_user <evalgit@example.com>
…aftercms#4833) * [8407] Add 'include children' option to PublishDialog. Prevent publishing only folders * [8407] Avoid duplicate items * [8407] Empty childrenItems when reverting dependencies changes * [8407] Fix validation on Array.every() on an empty array returns true * [8407] calculatePackage subscription cleanup * [8407] set 'includeChildren' to true if mainItems are all folders * [8407] Set initial state of 'includeChildren' based on mainItems being folders --------- Co-authored-by: git_repo_user <evalgit@example.com>
* [7418] Update tokenized prop name * [7418] Create commonDescriptors to reuse --------- Co-authored-by: git_repo_user <evalgit@example.com>
…ms#4840) * [8599] Update the UI to use the new available languages API * Return empty array if undefined * CHANGELOG update --------- Co-authored-by: git_repo_user <evalgit@example.com>
) * [8595] Update the UI to consume the new create site API * Update token authentication form validation * Update CreateSiteMeta siteName type to name * Refactor authentication handling to remove username requirement for token authentication --------- Co-authored-by: git_repo_user <evalgit@example.com>
…#4841) * [8598] Update the UI to consume the new dependencies APIs * [8598] Update changelog * Fix changelog * Refactor error handling in BrokenReferencesDialogContainer to use extractErrorPayload * Handle error on fetchContentItem * Add comment stating why ContentItems are needed * Add loading state to edit button in RenameItemView * Guard against undefined lightItems, use extractErrorPayload --------- Co-authored-by: git_repo_user <evalgit@example.com>
…all-ui-deps-eacba4f3c2' into dependabot/npm_and_yarn/develop/all-ui-deps-eacba4f3c2 # Conflicts: # ui/app/package.json # yarn.lock
#4802
#4801
Summary by CodeRabbit