Skip to content

Dependabot/npm and yarn/develop/all UI deps eacba4f3c2#4823

Merged
sumerjabri merged 33 commits into
craftercms:developfrom
jvega190:dependabot/npm_and_yarn/develop/all-ui-deps-eacba4f3c2
Apr 22, 2026
Merged

Dependabot/npm and yarn/develop/all UI deps eacba4f3c2#4823
sumerjabri merged 33 commits into
craftercms:developfrom
jvega190:dependabot/npm_and_yarn/develop/all-ui-deps-eacba4f3c2

Conversation

@jvega190

@jvega190 jvega190 commented Mar 12, 2026

Copy link
Copy Markdown
Member

#4802
#4801

Summary by CodeRabbit

  • Chores
    • Updated numerous dependencies and developer tooling across the app and simplified the CI lint script to run the standard linter command, improving build/toolchain consistency.
  • Bug Fixes
    • Fixed form value deserialization for array items when using advanced path matchers, improving reliability of complex form data handling.

@coderabbitai

coderabbitai Bot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@jvega190 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 18 minutes and 41 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 18 minutes and 41 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7ae75e95-c040-4e81-83d7-4931546492b5

📥 Commits

Reviewing files that changed from the base of the PR and between fa1577e and a66bfa4.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (78)
  • ui/app/package.json
  • ui/app/src/CHANGELOG.md
  • ui/app/src/components/ActivityDashlet/utils.tsx
  • ui/app/src/components/BrokenReferencesDialog/BrokenReferencesDialogContainer.tsx
  • ui/app/src/components/ContentTypeManagement/components/EditTypeView.tsx
  • ui/app/src/components/ContentTypeManagement/components/TypeDetailsView.tsx
  • ui/app/src/components/ContentTypeManagement/controlMap.ts
  • ui/app/src/components/ContentTypeManagement/controls/RichTextEditor.tsx
  • ui/app/src/components/ContentTypeManagement/descriptors/controls/awsFileUpload.ts
  • ui/app/src/components/ContentTypeManagement/descriptors/controls/checkbox.ts
  • ui/app/src/components/ContentTypeManagement/descriptors/controls/checkboxGroup.ts
  • ui/app/src/components/ContentTypeManagement/descriptors/controls/commonDescriptors.ts
  • ui/app/src/components/ContentTypeManagement/descriptors/controls/dateTime.ts
  • ui/app/src/components/ContentTypeManagement/descriptors/controls/disabled.ts
  • ui/app/src/components/ContentTypeManagement/descriptors/controls/dropdown.ts
  • ui/app/src/components/ContentTypeManagement/descriptors/controls/fileName.ts
  • ui/app/src/components/ContentTypeManagement/descriptors/controls/forceHttps.ts
  • ui/app/src/components/ContentTypeManagement/descriptors/controls/imagePicker.ts
  • ui/app/src/components/ContentTypeManagement/descriptors/controls/index.ts
  • ui/app/src/components/ContentTypeManagement/descriptors/controls/input.ts
  • ui/app/src/components/ContentTypeManagement/descriptors/controls/internalName.ts
  • ui/app/src/components/ContentTypeManagement/descriptors/controls/label.ts
  • ui/app/src/components/ContentTypeManagement/descriptors/controls/linkInput.ts
  • ui/app/src/components/ContentTypeManagement/descriptors/controls/linkTextarea.ts
  • ui/app/src/components/ContentTypeManagement/descriptors/controls/linkedDropdown.ts
  • ui/app/src/components/ContentTypeManagement/descriptors/controls/localeSelector.ts
  • ui/app/src/components/ContentTypeManagement/descriptors/controls/nodeSelector.ts
  • ui/app/src/components/ContentTypeManagement/descriptors/controls/numericInput.ts
  • ui/app/src/components/ContentTypeManagement/descriptors/controls/pageNavOrder.ts
  • ui/app/src/components/ContentTypeManagement/descriptors/controls/rte.ts
  • ui/app/src/components/ContentTypeManagement/descriptors/controls/textarea.ts
  • ui/app/src/components/ContentTypeManagement/descriptors/controls/time.ts
  • ui/app/src/components/ContentTypeManagement/descriptors/controls/transcodedVideoPicker.ts
  • ui/app/src/components/ContentTypeManagement/descriptors/controls/videoPicker.ts
  • ui/app/src/components/ContentTypeManagement/utils.ts
  • ui/app/src/components/CreateFileDialog/CreateFileDialogContainer.tsx
  • ui/app/src/components/CreateFolderDialog/CreateFolderContainer.tsx
  • ui/app/src/components/CreateSiteDialog/CreateSiteDialog.tsx
  • ui/app/src/components/CreateSiteDialog/CreateSiteDialogContainer.tsx
  • ui/app/src/components/CreateSiteDialog/GitForm.tsx
  • ui/app/src/components/DependenciesDialog/DependenciesDialogContainer.tsx
  • ui/app/src/components/DependenciesDialog/DependenciesDialogUI.tsx
  • ui/app/src/components/DependenciesDialog/utils.tsx
  • ui/app/src/components/DuplicateSiteDialog/DuplicateSiteDialog.tsx
  • ui/app/src/components/FormsEngine/controls/Checkbox.tsx
  • ui/app/src/components/FormsEngine/controls/CheckboxGroup.tsx
  • ui/app/src/components/FormsEngine/controls/FileName.tsx
  • ui/app/src/components/FormsEngine/controls/Label.tsx
  • ui/app/src/components/FormsEngine/controls/RichTextEditor.tsx
  • ui/app/src/components/FormsEngine/dataSourceHooks/useConsolidatedItemPickerData.ts
  • ui/app/src/components/FormsEngine/lib/controlMap.ts
  • ui/app/src/components/FormsEngine/lib/formUtils.tsx
  • ui/app/src/components/FormsEngine/lib/validators.ts
  • ui/app/src/components/FormsEngine/lib/valueRetrievers.ts
  • ui/app/src/components/FormsEngine/lib/valueSerializers.ts
  • ui/app/src/components/GitAuthForm/GitAuthForm.tsx
  • ui/app/src/components/ItemDisplay/ItemDisplay.tsx
  • ui/app/src/components/NewRemoteRepositoryDialog/NewRemoteRepositoryDialogContainer.tsx
  • ui/app/src/components/NewRemoteRepositoryDialog/utils.ts
  • ui/app/src/components/PublishDialog/PublishDialogContainer.tsx
  • ui/app/src/components/RecentlyPublishedDashlet/RecentlyPublishedDashlet.tsx
  • ui/app/src/components/RenameAssetDialog/RenameAssetDialog.tsx
  • ui/app/src/components/RenameContentDialog/RenameContentDialog.tsx
  • ui/app/src/components/RenameContentDialog/RenameContentDialogContainer.tsx
  • ui/app/src/components/RenameDialogBody/RenameItemView.tsx
  • ui/app/src/components/SetWorkflowStateDialog/SetItemStateDialog.tsx
  • ui/app/src/components/SetWorkflowStateDialog/SetItemStateDialogContainer.tsx
  • ui/app/src/components/WorkflowStateManagement/WorkflowStateManagement.tsx
  • ui/app/src/hooks/useWindowWidth.ts
  • ui/app/src/models/ContentType.ts
  • ui/app/src/models/Site.ts
  • ui/app/src/services/configuration.ts
  • ui/app/src/services/contentTypes.ts
  • ui/app/src/services/dependencies.ts
  • ui/app/src/services/sites.ts
  • ui/app/src/utils/itemActions.ts
  • ui/app/src/utils/path.ts
  • ui/app/src/utils/system.ts

Walkthrough

Multiple package.json manifests across the repo have dependency/devDependency version bumps; one code change updates a predicate in deserializeContentDoc to accept string | Matcher and treat only string paths ending with .item as arrays.

Changes

Cohort / File(s) Summary
Root package
package.json
Updated devDependencies and one public dependency versions (eslint, @eslint/*, rollup, @rollup/plugin-commonjs, @types/node, globals, rimraf, @prettier/plugin-xml) and simplified lint:ci script from eslint --flag unstable_config_lookup_from_file . to eslint ..
UI app package
ui/app/package.json
Broad set of dependency and devDependency version upgrades (MUI packages, @atlaskit/pragmatic-drag-and-drop, @prettier/plugin-xml, fast-xml-parser, graphql, jotai, marked, monaco-graphql, react-router, react-window, video.js, ESLint/TS toolchain, rollup, rimraf, etc.) — manifests only.
UI guest package
ui/guest/package.json
Minor version bumps for MUI and build tooling (@formatjs/cli, @swc/core, @types/jquery, rollup).
UI legacy package
ui/legacy/package.json
SWC tooling devDependency bumps (@swc/cli, @swc/core).
UI npm-content package
ui/npm-content/package.json
Version bumps for css-loader, @types/jquery, rimraf, and webpack.
UI uppy package
ui/uppy/package.json
Bumped preact and eslint versions; removed eslintConfig block.
Forms engine code
ui/app/src/components/FormsEngine/lib/valueRetrievers.ts
Imported Matcher and changed isArray predicate in deserializeContentDoc to accept `string

Sequence Diagram(s)

(omitted — changes are dependency/version updates plus a localized predicate adjustment that does not introduce a new multi-component sequential flow)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • rart
  • sumerjabri
🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only contains two GitHub PR links without any context, failing to meet the repository's description template requirements. Add a detailed description explaining what dependencies were updated and why, following the repository's template structure.
Title check ❓ Inconclusive The title is vague and non-descriptive, using an auto-generated Dependabot branch name instead of a clear summary of the changes. Replace with a descriptive title like 'Update all UI dependencies and development tools' that clearly conveys the main purpose of the changes.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@ui/uppy/package.json`:
- Line 54: Remove the eslintConfig field from package.json (the "eslintConfig"
object currently containing parserOptions.sourceType) because ESLint v10 no
longer supports package.json configs; delete that key and rely on the root flat
config or add a dedicated flat config file (eslint.config.mjs) if this package
needs local overrides; ensure no other tooling expects the removed field and
update any project-level documentation or scripts that referenced
"eslintConfig".

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c387e362-9dd2-469b-a2e2-925a189f6e72

📥 Commits

Reviewing files that changed from the base of the PR and between e652780 and 80d8c0a.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (7)
  • package.json
  • ui/app/package.json
  • ui/app/src/components/FormsEngine/lib/valueRetrievers.ts
  • ui/guest/package.json
  • ui/legacy/package.json
  • ui/npm-content/package.json
  • ui/uppy/package.json

…o dependabot/npm_and_yarn/develop/all-ui-deps-eacba4f3c2

# Conflicts:
#	ui/app/src/components/FormsEngine/lib/valueRetrievers.ts
…stable_config_lookup_from_file flag from root package.json
@jvega190 jvega190 marked this pull request as ready for review March 17, 2026 17:42
@jvega190 jvega190 requested a review from rart as a code owner March 17, 2026 17:42

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@ui/uppy/package.json`:
- Line 54: Add a flat-config override in the ESLint config (eslint.config.mjs)
that targets the Uppy source files by adding an override entry with files:
['ui/uppy/src/**/*.{ts,tsx}'] and parserOptions.sourceType: 'module' (i.e.,
sourceType: 'module') so ESM imports/exports parse correctly; insert this new
override before the existing global TS/TSX override block referenced around
eslint.config.mjs:88 to ensure it takes precedence for ui/uppy files.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a7a26dc5-862b-4da6-91ad-ebeed5b94db7

📥 Commits

Reviewing files that changed from the base of the PR and between e4ba74b and fa1577e.

📒 Files selected for processing (2)
  • package.json
  • ui/uppy/package.json

Comment thread ui/uppy/package.json
jvega190 and others added 12 commits March 20, 2026 11:11
* [7418] Label control

* [7418] Standardize fallback handling

* [7418] Add dompurify sanitization when setting inner html

* [7418] Remove defaultValue

* [7418] use getPropertyValue in Label control

* [7418] Remove renderAsHTML property from label descriptor, use minimal setup of tinymce in text field

* [7418] Add RTE wrapper for TypeBuilder, update label control to use rte for text field, with `craftercms-label-control`. Update RichTextEditor control to support defaultInitOptions prop

* [7418] Add dompurify

* [7418] Add dompurify

* [7418] fix package.json format

* [7418] Add dompurify
* [7418] Checkbox readonly and defaultValue updates

* [7418] Improve Checkbox readonly value extraction

* [7418] Remove retrieving logic from checkbox control, update retrieveFieldValue to omit empty strings as defaultValue

* [7418] Update checkbox validator, fix retrieveFieldValue fieldValue calculation

* [7418] Update booleanFieldExtractor to return false if nullish value
…ew DataSource type instead of legacy. (craftercms#4806)

* [8216] Update dropTargetsLookup in parseLegacyFormDefinition to use new DataSource type instead of legacy

* [8216] Fix NodeSelector create component

* [8216] Remove unnecessary cast
…ested the publish (craftercms#4831)

* [8444] Approver user listed in Dashboard is always the user that requested the publish

* [8444] Fix approver for requests in RecentlyPublishedDashlet
…bal configs are unset (craftercms#4797)

* Fix error handling in EditTypeView to ensure proper message display, add type to error
* Update field validation logic
* Enhance listDirection parsing
* Guard placeholder items during filtering
* Validate window in useWindowWidth
* Parse minSize safely
* Update validator to consider empty (or non-array) values
* Simplify validateFieldValue logic
* Remove unused/duplicate util
* Remove unused import
* Move utils to bottom of component
* Update CheckboxGroup to render a max of 2 columns, and remove rendering of 3 columns logic
* Move checkboxGroup validator to fn
* Add skeleton for loading state, use props utils
* Fix property for selectAll
* Update indeterminate and checked conditions of selectAll checkbox to consider filtering
* Update checkboxGroupValidator currentValue type
* Return undefined for finalOptions nullish options
)

* Fix datasources form in TB2
* Retrieve/pass field to serializer
…ftercms#4808)

* Workflow states options should only display valid options
* Add error handling on fetchPublishingTargets
…orrupts form (craftercms#4838)

* [7511] cleanupStaleDatasourceValues

* [7511] Cleanup datasource values from xml

* [7511] Remove comment

* [7511] Update selector in EditTypeView to use :scope for value element

* [7511] consider parse errors

---------

Co-authored-by: git_repo_user <evalgit@example.com>
jvega190 and others added 8 commits April 9, 2026 23:44
)

* [8569] Update staging publishing target indicator in UI

* [8569] Update comment

* [8569] Added util `shouldItemShowAsStaged`

* [7418] Update shouldItemShowAsStaged to avoid casting item
…aftercms#4833)

* [8407] Add 'include children' option to PublishDialog. Prevent publishing only folders

* [8407] Avoid duplicate items

* [8407] Empty childrenItems when reverting dependencies changes

* [8407] Fix validation on Array.every() on an empty array returns true

* [8407] calculatePackage subscription cleanup

* [8407] set 'includeChildren' to true if mainItems are all folders

* [8407] Set initial state of 'includeChildren' based on mainItems being folders

---------

Co-authored-by: git_repo_user <evalgit@example.com>
* [7418] Update tokenized prop name

* [7418] Create commonDescriptors to reuse

---------

Co-authored-by: git_repo_user <evalgit@example.com>
…ms#4840)

* [8599] Update the UI to use the new available languages API

* Return empty array if undefined

* CHANGELOG update

---------

Co-authored-by: git_repo_user <evalgit@example.com>
)

* [8595] Update the UI to consume the new create site API

* Update token authentication form validation

* Update CreateSiteMeta siteName type to name

* Refactor authentication handling to remove username requirement for token authentication

---------

Co-authored-by: git_repo_user <evalgit@example.com>
…#4841)

* [8598] Update the UI to consume the new dependencies APIs

* [8598] Update changelog

* Fix changelog

* Refactor error handling in BrokenReferencesDialogContainer to use extractErrorPayload

* Handle error on fetchContentItem

* Add comment stating why ContentItems are needed

* Add loading state to edit button in RenameItemView

* Guard against undefined lightItems, use extractErrorPayload

---------

Co-authored-by: git_repo_user <evalgit@example.com>
…all-ui-deps-eacba4f3c2' into dependabot/npm_and_yarn/develop/all-ui-deps-eacba4f3c2

# Conflicts:
#	ui/app/package.json
#	yarn.lock
@sumerjabri sumerjabri merged commit 8719fc7 into craftercms:develop Apr 22, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants