Skip to content

fixed #14738 gui recheck file not working properly when importing compile_commands.json #8625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wjakobsson wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −3
Open

fixed #14738 gui recheck file not working properly when importing compile_commands.json #8625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4462bcc
fixed #14738
Jun 3, 2026
881aaf9
fix
Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions gui/mainwindow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,13 +559,24 @@ void MainWindow::saveSettings() const
mUI->mResults->saveSettings(mSettings);
}

void MainWindow::doAnalyzeProject(ImportProject p, const bool checkLib, const bool checkConfig)
void MainWindow::doAnalyzeProject(ImportProject p, const bool checkLib, const bool checkConfig, const QStringList& recheckFiles)
{
Settings checkSettings;
auto supprs = std::make_shared<Suppressions>();
if (!getCppcheckSettings(checkSettings, *supprs))
return;

// filter requested files
if (!recheckFiles.isEmpty()) {
QSet<QString> filesToCheck;
for (const QString& file : recheckFiles) {
filesToCheck.insert(file);
}
p.fileSettings.remove_if([&](const FileSettings& fs) {
return !filesToCheck.contains(QString::fromStdString(fs.filename()));
});
}

clearResults();

mIsLogfileLoaded = false;
Expand Down Expand Up @@ -1958,7 +1969,7 @@ void MainWindow::analyzeProject(const ProjectFile *projectFile, const QStringLis
msg.exec();
return;
}
doAnalyzeProject(p, checkLib, checkConfig); // TODO: avoid copy
doAnalyzeProject(p, checkLib, checkConfig, recheckFiles); // TODO: avoid copy
return;
}

Expand Down
2 changes: 1 addition & 1 deletion gui/mainwindow.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ private slots:
* @param checkLib Flag to indicate if library should be checked
* @param checkConfig Flag to indicate if the configuration should be checked.
*/
void doAnalyzeProject(ImportProject p, bool checkLib = false, bool checkConfig = false);
void doAnalyzeProject(ImportProject p, bool checkLib = false, bool checkConfig = false, const QStringList& recheckFiles = QStringList());

/**
* @brief Analyze all files specified in parameter files
Expand Down
Loading