Easter Fun! Shapes and Colors - #17
Open
nicole026 wants to merge 1 commit into
Open
Conversation
…dd more for the other holidays. if its trash feel free to trash it and ill mess around for the next holiday, but i had this idea and wanted to play with it
nicole026
requested review from
bisby,
indi-rin and
rileybutterfield
as code owners
April 5, 2026 06:34
indi-rin
reviewed
Jun 24, 2026
Comment on lines
+75
to
+78
| /** @deprecated Use getDateThemeIdForSeed — same behavior. */ | ||
| export function getShapeThemeIdForSeed(seed: string): DateThemeId { | ||
| return getDateThemeIdForSeed(seed); | ||
| } |
Collaborator
There was a problem hiding this comment.
Nit: It doesn't look like this function is actually used anywhere. I'm guessing the AI added this, then in a later refinement went in a different direction and just assumed it was a legacy function that needed to maintain support. (I've seen AI do this before.) Let's just delete it instead to avoid confusion.
indi-rin
reviewed
Jun 24, 2026
Comment on lines
+8
to
+9
| /** @deprecated Use DateThemeId — same union, kept for any external imports. */ | ||
| export type ShapeThemeId = DateThemeId; |
Collaborator
There was a problem hiding this comment.
Same comment as below (sorry, I'm reviewing this in reverse order lol) where this type isn't actually used anywhere so can just be deleted.
🔥
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes do the following:
** IMPORTANT ** I vibe coded the absolute HELL out of this (aka please do not blindly trust me, i did not read over everything that was generated) but wanted to try getting it out ASAP to make it in time for Easter. that said, this code might be trash... but it looked like it was working!!
I want to do this for other holidays so if this sucks for any reason and you dont want to merge it -- it changes a LOT? -- feel free to kick it and i'll make this good/better for the next holiday!
I'd love to do this and have it be a fun surprise for y'all like i got on april fool's day, but i don't see how that's possible heh maybe if this works and i do it for other holidays.... dont look? lol happy easter
[Edit] last note: playing it myself now and the game it is lowkey very difficult lolololololol if you hate this feel free to just nix it you will not hurt my feelings