feat: schedule the next pass from the previous one across restarts - #536
Merged
Conversation
The interval timer restarted its period at container boot: with the startup pass skipped, the first tick landed one full interval after boot rather than one interval after the recorded previous run, so a restart delayed the cadence by up to one interval. scheduler v4.2.0 adds the phase half of the last-run record, and this wires it in: RunLoop's first tick now fires at the record's remaining time, so a run 30 minutes old on a 1h schedule ticks 30 minutes after boot. Restarts neither add runs nor delay the cadence. The README alert example's absence window re-derives back down accordingly, since a restart no longer stretches the longest legal gap: 50h to 26h (one DEEP_SCAN_INTERVAL plus pass runtime, plus margin).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interval timer restarted its period at container boot: with the
startup pass skipped, the first tick landed one full interval after boot
rather than one interval after the recorded previous run, so a restart
delayed the cadence by up to one interval.
scheduler v4.2.0 adds the phase half of the last-run record, and this
wires it in: RunLoop's first tick now fires at the record's remaining
time, so a run 30 minutes old on a 1h schedule ticks 30 minutes after
boot. Restarts neither add runs nor delay the cadence.
The README alert example's absence window re-derives back down
accordingly, since a restart no longer stretches the longest legal gap:
50h to 26h (one DEEP_SCAN_INTERVAL plus pass runtime, plus margin).