Remove redundant BEGIN eval block for Crypt::OpenSSL::Bignum#194
Open
toddr-bot wants to merge 1 commit into
Open
Remove redundant BEGIN eval block for Crypt::OpenSSL::Bignum#194toddr-bot wants to merge 1 commit into
toddr-bot wants to merge 1 commit into
Conversation
The BEGIN block that conditionally required Crypt::OpenSSL::Bignum dates from when Bignum was an optional dependency. Since commit e1c9975 made it a hard requirement via `use Crypt::OpenSSL::Bignum`, the BEGIN eval block is dead code — if the `use` fails, compilation aborts before reaching the BEGIN block. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BEGIN { eval { require Crypt::OpenSSL::Bignum } }block from RSA.pmuse Crypt::OpenSSL::Bignum;as a hard requirement, the BEGIN block is unreachable: ifusefails, compilation aborts before the BEGIN block runsTest plan
make test— all 667 tests passusestatement already guarantees Bignum is loaded🤖 Generated with Claude Code