Remove unnecessary libssl dependency#188
Draft
toddr-bot wants to merge 1 commit into
Draft
Conversation
This module performs RSA operations using libcrypto only — no TLS functions from libssl are called. Remove the unused #include <openssl/ssl.h> from RSA.xs, drop -lssl from the Unix link flags in Makefile.PL, and update the Windows hints to query/link only libcrypto. This reduces build dependencies, allowing the module to compile in environments where only libcrypto headers and libraries are installed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Drop the unused libssl linkage and
#include <openssl/ssl.h>— this module only calls libcrypto functions.Why
RSA.xs performs key generation, encryption, signing, and verification using libcrypto's RSA/EVP API. It has never called any TLS function from libssl. The
-lssllink flag andssl.hinclude were inherited from early boilerplate but serve no purpose.Removing them:
How
#include <openssl/ssl.h>(line 22)-lssl -lcryptoto-lcryptopkg-config --libs libcryptoand remove ssl libraries from manual fallbacksTesting
lddconfirms onlylibcrypto.so.3is linked, no libssl🤖 Generated with Claude Code