TOTP via PyOTP#11
Open
stefango79 wants to merge 2 commits into
Open
Conversation
Author
|
I cleaned up the Dockerfile. PIP install was obsolete. Pretty sure it works as expected now. |
|
@couchtyp this looks much more in line with what I would expect from 2fa support. Without something like this, I need to always have an external mechanism that updates the configuration file all the time before invoking certbot, which is quite annoying. Any reason you don't want to merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I did some changes for 2FA. Now it's using PyOTP to generate the access token. I tested it with my Schlundtech account via the Docker version. I also edited the setup.py install_requiremnts, but I didn't test it his way. Is there a better way for Docker than RUN pip install for PyOTP?
This is my first (and probably last) Python program, so I didn't change the parameter name for TOKEN, as I didn't wont to break anything. Maybe the name is not the best anymore.
I tested it a few times with my account and also with more than one domain via the -d option. (domain1.com, *.domain1.com, domain2.com, *.domain2.com).
Let me know, if you need some further testing or some changes.
Best regards from Ruhrpott
Stefan