Conversation
Rename application to TicketPilot for v2.0.0
Finalize Ticket Pilot metadata and Cloudflare defaults
Change cloudflared replicas from 2 to 1 in docker stack for dev
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 75fc4d89f4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| minimum_stop_utc = ensure_utc(job.rounded_start_utc) + timedelta( | ||
| minutes=minimum_time_entry_duration_minutes(job.work_location) | ||
| ) | ||
| return max(ensure_utc(rounded_stop_utc), minimum_stop_utc) |
There was a problem hiding this comment.
When an active On-Site job has a rounded start at or after 11:00 pm in Detroit, adding the one-hour minimum here produces an end timestamp on the following local date. The preceding date check in rounded_stop_for_active_job() happens before this clamp, while end_job() and direct submission validate only the duration, so the cross-date entry can be persisted and sent to Autotask even though Review cannot represent it as one valid job date. Reject the infeasible stop/location change rather than returning a next-day minimum.
AGENTS.md reference: AGENTS.md:L440-L442
Useful? React with 👍 / 👎.
| data-rounded-start-utc="{{ active_job.rounded_start_utc|utc_iso }}" | ||
| data-initial-rounded-stop-utc="{{ rounded_stop_utc|utc_iso }}" | ||
| data-initial-rounded-stop-local-time="{{ rounded_stop_utc|local_time }}" | ||
| data-minimum-duration-minutes="{% if active_job.work_location and active_job.work_location.value == 'on_site' %}60{% else %}15{% endif %}" |
There was a problem hiding this comment.
This template independently hardcodes the Remote and On-Site minimums even though minimum_time_entry_duration_minutes() is the authoritative business rule. Any future adjustment or added work-location case would make the initially rendered browser clamp disagree with the server until a save response refreshes it; pass the helper-derived minimum into the template instead.
AGENTS.md reference: AGENTS.md:L444-L445
Useful? React with 👍 / 👎.
1 participant
Summary
Start a time entrywordingValidation
git diff --checkpassed