Skip to content

fix: correct contact heading hierarchy#42

Merged
corwinm merged 1 commit into
mainfrom
fix/contact-heading-hierarchy
Jul 13, 2026
Merged

fix: correct contact heading hierarchy#42
corwinm merged 1 commit into
mainfrom
fix/contact-heading-hierarchy

Conversation

@corwinm

@corwinm corwinm commented Jul 13, 2026

Copy link
Copy Markdown
Owner

Summary

  • change the homepage contact card heading from h4 to h3
  • remove the heading-level skip beneath the Connect with me section’s h2
  • preserve the existing 24px visual styling and all other contact-card behavior
  • add a focused regression test for the heading hierarchy

TDD

  • RED: the focused test failed because Find me online was still rendered as an h4
  • GREEN: the focused hierarchy test passes with the card heading rendered as h3

Validation

  • pnpm lint — passed with 0 warnings and 0 errors
  • pnpm typecheck — passed
  • pnpm test — 44/44 passed across 13 files
  • pnpm build — passed
  • git diff --check — passed
  • production accessibility tree confirms Connect with me is level 2 and Find me online is level 3
  • production DOM confirms no matching h4 remains
  • computed contact-card heading size remains 24px
  • independent pre-commit review passed with no security concerns or logic errors

Scope

This is a semantic accessibility fix only; the visible contact-card presentation is unchanged. The separate resume-refinement worktree and its uncommitted files were not modified.

@vercel

vercel Bot commented Jul 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
corwinm-remix Ready Ready Preview, Comment Jul 13, 2026 9:31pm

@corwinm
corwinm merged commit 0df3682 into main Jul 13, 2026
3 checks passed
@corwinm
corwinm deleted the fix/contact-heading-hierarchy branch July 13, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant