fix(dist): move msvc-crt-static to workspace.metadata so cargo-dist reads it#17
Merged
Merged
Conversation
…eads it The 0.2.0 Windows dist build failed on a RuntimeLibrary mismatch (LNK2038): pyke's ORT is dynamic-CRT (MD) while cargo-dist's +crt-static default built whisper.cpp/Rust static (MT). The msvc-crt-static=false fix was under [package.metadata.dist], which cargo-dist ignores with a warning — it only reads the key from workspace.metadata. Move it there so the dist build actually links the dynamic CRT.
Runs the real cargo-dist `dist build` on windows-2022 so it reads the moved key and links as the release does — a plain cargo build bypasses the CRT flag and false-passed last time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dist buildfailed on a RuntimeLibrary mismatch (LNK2038): pyke's ONNX Runtime is a dynamic-CRT (MD) static lib, while cargo-dist's+crt-staticdefault built whisper.cpp and Rust static (MT).msvc-crt-static = falsefix was under[package.metadata.dist], which cargo-dist ignores (warning: "only accepted in workspace.metadata"). Moves it to[workspace.metadata.dist]so the dist build links the dynamic CRT and every object agrees on MD.Test plan
Windows dist CRT smokeruns the realdist build --target x86_64-pc-windows-msvconwindows-2022and links — the temporary leg, dropped before mergedist-buildlegs green through publish