Bug/prompt truncated#72
Open
mygibbs wants to merge 6 commits into
Open
Conversation
Implemented Lesson Creation, Lessons Page, and other functionalities. For more information view Sprint02 Stories on our ZenHub board: https://app.zenhub.com/workspaces/smip-5c5dd5323547567638dbb48a/board?repos=169785349
When doing last minute testing found a bug in the way we validate inputs on the lesson creation form. Would not catch cases where invalid characters followed numbers. Changed implementation to check that all characters are numbers. This bug managed to get through all previous tests we did and that is why the fix is happening here.
When doing last minute testing found a bug in the way we validate inputs on the lesson creation form. Would not catch cases where invalid characters followed numbers. Changed implementation to check that all characters are numbers. This bug managed to get through all previous tests we did and that is why the fix is happening here.
I updated the README so that another group can fork this repo, and run our acceptance tests.
…ncluded notes on how to make a more effective solution. The best solution that I've included is making a custom ValidationEntry and MaxLengthValidation class that will perform validation depending on developer/client needs. All of the other textboxes require similar changes which is why this option is the best (will require the least changes and result in the least duplication of code. Please let me know if you have any questions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference to #65.