Add option to disable speech recognition#282
Open
castawait wants to merge 1 commit into
Open
Conversation
Adds a Disabled speech recognition mode so users who want neither the cloud model nor the on-device model can turn transcription off, with no sign in and no model download. When selected, STTRouter.canServeSession() returns false and the watch gets the existing FailDisabled result, the same path used today when speech recognition is unavailable. Closes coredevices#269 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #269
Problem
Speech recognition offers a choice between the cloud model and the ~670MB on-device model, but no way to turn it off. A user who wants neither is stuck: selecting Cloud prompts a sign in, and the only way to opt out is to download the local model and then delete it, which reverts to Cloud.
Change
Adds a Disabled speech recognition mode. Selecting it in Settings under Offline Speech Recognition turns transcription off with no sign in and no model download.
When the mode is Disabled, STTRouter.canServeSession() returns false, so VoiceSessionManager replies to the watch with the existing FailDisabled result. That is the same path used today when speech recognition is unavailable, so there is no new on-device behaviour.
Notes
Selection, routing, and the bug report summary already switch on sttConfig.mode, so the change is a new enum value plus the branches that handle it. The mode is serialized by name, so existing configs are unaffected.
Claude helped put this PR together.