timeline: fix double dot during exit animation on round displays#1793
Open
jplexer wants to merge 1 commit into
Open
timeline: fix double dot during exit animation on round displays#1793jplexer wants to merge 1 commit into
jplexer wants to merge 1 commit into
Conversation
On timeline exit the peek icon folds into a dot rendered by the kino reel in global coordinates, landing at the exact screen center. When the fold stops, show_dot is enabled and the peek layer then also draws the static dot, centered in its local bounds. With the Large content size style the peek layer frame is offset by peek_offset_y = -7, so both dots are visible simultaneously ~7 px apart until the compositor transition paints over them. Only enable the static dot when the kino layer is hidden; while it is visible it already renders its resting end-as-dot frame. Only reproduces on getafix: the dot animation is round-only and the peek frame offset only applies at PreferredContentSizeLarge (>=200 px displays). Verified before/after on qemu_gabbro with screendump bursts of the timeline exit. Fixes FIRM-2012 Fixes FIRM-3534 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Joshua Jun <lets@throw.rocks>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On timeline exit the peek icon folds into a dot rendered by the kino reel in global coordinates, landing at the exact screen center. When the fold stops, show_dot is enabled and the peek layer then also draws the static dot, centered in its local bounds. With the Large content size style the peek layer frame is offset by peek_offset_y = -7, so both dots are visible simultaneously ~7 px apart until the compositor transition paints over them.
Only enable the static dot when the kino layer is hidden; while it is visible it already renders its resting end-as-dot frame.
Only reproduces on getafix: the dot animation is round-only and the peek frame offset only applies at PreferredContentSizeLarge (>=200 px displays). Verified before/after on qemu_gabbro with screendump bursts of the timeline exit.
Fixes FIRM-2012
Fixes FIRM-3534