fw/shell/normal: show a dialog when a quick launch app is not installed#1719
Open
ericmigi wants to merge 1 commit into
Open
fw/shell/normal: show a dialog when a quick launch app is not installed#1719ericmigi wants to merge 1 commit into
ericmigi wants to merge 1 commit into
Conversation
Quick launch preferences store the app UUID. When the phone offloads an app to stay under the locker sync limit, it deletes the app's BlobDB record from the watch, so the UUID no longer resolves to an install id. All quick launch paths treated this as "nothing assigned": a long press opened the Quick Launch setup menu with the shortcut showing as unassigned, a single click asserted in app_manager_put_launch_app_event() and rebooted the watch, and combos silently did nothing. An enabled quick launch preference always has a valid UUID (enforced by prefs normalization), so a failed lookup on an enabled button means the app is missing from the watch, not unassigned. Show a dialog telling the user to re-add the app from the phone instead of pretending the button is unassigned. Fixes FIRM-3347 Fixes FIRM-2825 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Eric Migicovsky <eric@repebble.com>
Member
|
mhh the correct way would be for a quick launch app to not get offloaded (cc: @sjp4 ) |
Member
i'm guessing this is most likely to happen when the user uninstalled the app. The hitting-the-locker-sync-limit case is very unlikely (unless you are eric) |
Collaborator
Author
|
the dialog is still bad and could be updated easily with this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick launch preferences store the app UUID. When the phone offloads an app to stay under the locker sync limit, it deletes the app's BlobDB record from the watch, so the UUID no longer resolves to an install id. All quick launch paths treated this as "nothing assigned": a long press opened the Quick Launch setup menu with the shortcut showing as unassigned, a single click asserted in app_manager_put_launch_app_event() and rebooted the watch, and combos silently did nothing.
An enabled quick launch preference always has a valid UUID (enforced by prefs normalization), so a failed lookup on an enabled button means the app is missing from the watch, not unassigned. Show a dialog telling the user to re-add the app from the phone instead of pretending the button is unassigned.
Fixes FIRM-3347
Fixes FIRM-2825