Handle disabled workflows gracefully#7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When dispatching a workflow that has been disabled in the GitHub UI, the API returns an error ending with "a disabled workflow". Currently the action treats this as a hard failure via
core.setFailed(), which fails the entire step.This is unnecessarily disruptive — a disabled workflow is an expected state, not an error. The caller may want the pipeline to continue even if one target workflow is turned off.
Solution
Catch errors ending with "a disabled workflow" and emit a warning (
core.warning()) instead of failing the step. The action returns successfully, allowing downstream steps to continue.Backported from
benc-uk/workflow-dispatchv1.3.x.Test plan