-
Notifications
You must be signed in to change notification settings - Fork 80
Add failure mode taxonomy vocabulary and synthesize_traces focus guidance to SYSTEM_PROMPT #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
3b73a79
0b52a6a
3c569af
5110e6f
cd27a4c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -265,20 +265,11 @@ export function FileImportDialog({ | |
| Cancel import | ||
| </Button> | ||
| ) : ( | ||
| <> | ||
| <Button onClick={() => onOpenChange(false)} variant="ghost"> | ||
| Close | ||
| </Button> | ||
| <Button | ||
| onClick={() => { | ||
| setActiveJobId(null); | ||
| setStep("choose"); | ||
| }} | ||
| variant={jobFailed ? "secondary" : "default"} | ||
| > | ||
| Start another import | ||
| </Button> | ||
| {jobFailed && latestJob ? ( | ||
| jobFailed && latestJob ? ( | ||
| <> | ||
| <Button onClick={() => onOpenChange(false)} variant="ghost"> | ||
| Close | ||
| </Button> | ||
| <Button | ||
| disabled={startImport.isPending} | ||
| onClick={() => | ||
|
|
@@ -288,8 +279,10 @@ export function FileImportDialog({ | |
| <RotateCcw className="mr-2 h-4 w-4" /> | ||
| Retry import | ||
| </Button> | ||
| ) : null} | ||
| </> | ||
| </> | ||
| ) : ( | ||
| <Button onClick={() => onOpenChange(false)}>Close</Button> | ||
| ) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Success import loses repeat actionMedium Severity After a successful import, the dialog footer now only shows Additional Locations (3)Reviewed by Cursor Bugbot for commit cd27a4c. Configure here. |
||
| ) | ||
| ) : null} | ||
| </div> | ||
|
|
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Import guard blocks retry finish
Low Severity
handleImportedsetscompletedImportRefto true beforeawait onFinish(). Ifonboarding.completeor navigation fails after a successful import, later import completions skiphandleImportedand no longer auto-complete onboarding, even though dialogs were already closed on the first attempt.Reviewed by Cursor Bugbot for commit cd27a4c. Configure here.