MAINTAINERS: add Dingyang Hu (jokemanfire) as a REVIEWER - #323
Open
Tim-Zhang wants to merge 1 commit into
Open
Conversation
Dingyang Hu has contributed to ttrpc-rust since 2024 across the runtime, async streaming, code generation, and Prost support. He is also an official reviewer of containerd/rust-extensions. Add him as a reviewer for ttrpc-rust. Signed-off-by: Tim Zhang <tim@hyper.sh>
Member
|
Thank you for this proposal. I am delighted to collaborate with all the experts in this warehouse. LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dingyang Hu (@jokemanfire) has been a long-term contributor to ttrpc-rust since 2024. He has authored 10 merged pull requests covering the runtime, async streaming, code generation, and Prost support:
View his merged ttrpc-rust pull requests
Most recently, he drove the long-running Prost support work in #286 through multiple rounds of review and brought it to completion.
Dingyang is already an official reviewer of containerd/rust-extensions and a member of the
@containerd/rust-reviewersteam:containerd/rust-extensions#443
I would like to invite him to serve officially as a reviewer for ttrpc-rust.
According to the containerd governance policy, this requires an explicit LGTM from the candidate and approval or LGTM from one third of the ttrpc-rust Committers.
CC @containerd/committers for awareness. Core Committer votes are welcome but non-binding for this non-core subproject.
Need explicit LGTM from @jokemanfire
This PR will remain open for at least seven days.