Skip to content

deps: bump wasmtime to 43.0.1#1106

Open
tanishiking wants to merge 3 commits intocontainerd:mainfrom
tanishiking:wasmtime43
Open

deps: bump wasmtime to 43.0.1#1106
tanishiking wants to merge 3 commits intocontainerd:mainfrom
tanishiking:wasmtime43

Conversation

@tanishiking
Copy link
Copy Markdown
Contributor

@tanishiking tanishiking commented Apr 14, 2026

No description provided.

jprendes
jprendes previously approved these changes Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tanishiking
tanishiking commented Apr 14, 2026
View reviewed changes
Comment thread crates/containerd-shim-wasmer/Cargo.toml
Comment on lines +12 to +13
wasmer = "6.1.0"
wasmer-wasix = "0.601.0"
Copy link
Copy Markdown
Contributor Author

@tanishiking tanishiking Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasmtime-wasi 43.0.1 requires url >= 2.5.7, and wasmer-package 0.600.1 pins url =2.5.2.
Updated them so it relax to url = ^2.5.

tanishiking
tanishiking commented Apr 14, 2026
View reviewed changes
Comment thread crates/containerd-shim-wasmtime/src/instance.rs

Self {
engine: wasmtime::Engine::new(&config)
.map_err(anyhow::Error::from)
Copy link
Copy Markdown
Contributor Author

@tanishiking tanishiking Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In wasmtime 43 wasmtime::Error becomes its own type separate from anyhow::Error.
We might want to adapt to the wasmtime::Error from anyhow::Error in future.

@jprendes
Copy link
Copy Markdown
Collaborator

jprendes commented Apr 15, 2026

@tanishiking , could you rebase on the latest main? it should include the musl fix.

@jprendes
Copy link
Copy Markdown
Collaborator

jprendes commented Apr 20, 2026

@tanishiking , it looks like there are some CI failures due to some methods being renamed in wasmtime. Do you mind looking into it?

@tanishiking
Copy link
Copy Markdown
Contributor Author

tanishiking commented Apr 21, 2026 •
edited
Loading

Ah yeah, bytecodealliance/wasmtime#12371 makes Config::async_support no op. And async APIs can be used without that. (not sure about lint and dependency-review)

@jprendes
Copy link
Copy Markdown
Collaborator

jprendes commented Apr 21, 2026

you should be able to fix the lints with make fix (you might need to run it more than once, and commit changes in between)

@tanishiking
Copy link
Copy Markdown
Contributor Author

tanishiking commented Apr 22, 2026

dependency-review failed because of GHSA-cq8v-f236-94qc
but it seems not very relevant to runwasi, because in the custom loggers under crates/containerd-shimkit there's no usage on rand I guess. We might wanna allow-ghsas: GHSA-cq8v-f236-94qc in GHA ?

Regarding wasmer update 60c8123 TBH I vibe coded and not fully understand how this change fix the problem 😓 (tried using WasiRunner but it didn't work)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jprendes jprendes jprendes left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

C-wasmer C-wasmtime

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tanishiking @jprendes