Add About page explaining the Constructor Fabric name#12
Conversation
New top-level About nav item (last position) linking to about.html, which covers the von Neumann / Constructor Theory origins of the name and the project mission. The page follows the same structure as the other pages (shared header/footer partials, page-hero plus content section) with page-scoped spacing tweaks so the heading flows directly into the text. Also adds about.html to sitemap.xml. Done with the help of: Claude Fable 5 Signed-off-by: sstimsu <timsus@gmail.com>
📝 WalkthroughWalkthroughThis PR adds a new about.html page for the Constructor Fabric site, including head metadata, styling, and a React-based content component (hero, prose, CTA, footer). It also adds an "About" navigation link in partials.jsx and registers the new page in sitemap.xml. ChangesAbout Page Addition
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant Browser
participant AboutHTML as about.html
participant Babel
participant ReactDOM
Browser->>AboutHTML: Request about.html
AboutHTML->>Babel: Load partials.jsx and inline JSX
Babel->>ReactDOM: Compile About component
ReactDOM->>Browser: Render SiteHeader, hero, prose, CtaStart, SiteFooter
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview deployment is ready: https://constructorfabric.github.io/website-previews/pr-12/ This preview is built from the latest commit on this PR. It is regenerated automatically on every push. Old previews are cleaned up after 30 days. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
about.html (1)
24-39: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueConsider consolidating page-scoped spacing overrides into styles.css over time.
Defining
.page-hero--compactand.section--aboutinline per page works but risks duplication/divergence if other pages later need similar spacing tweaks with the same class names but different values. Not blocking since this mirrors the PR's stated intent to keepstyles.cssuntouched.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@about.html` around lines 24 - 39, The page-scoped spacing overrides defined in the about page’s inline style block should be consolidated into styles.css when practical to avoid duplication and divergent values across pages. Move the `.page-hero--compact` and `.section--about` rules into the shared stylesheet and keep the about page markup only for page-specific usage, preserving the current spacing behavior while centralizing the definitions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@about.html`:
- Around line 24-39: The page-scoped spacing overrides defined in the about
page’s inline style block should be consolidated into styles.css when practical
to avoid duplication and divergent values across pages. Move the
`.page-hero--compact` and `.section--about` rules into the shared stylesheet and
keep the about page markup only for page-specific usage, preserving the current
spacing behavior while centralizing the definitions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 759e8231-4413-4113-85bb-7a59deac7efa
📒 Files selected for processing (3)
about.htmlpartials.jsxsitemap.xml
2 participants
What
Adds a new About page (
about.html) and a top-level About nav item in the last position, on both the desktop nav and the mobile drawer menu.The page content is "Why Constructor Fabric?" — the intellectual origins of the name (von Neumann's Universal Constructor, Deutsch's Constructor Theory) and the project mission.
How
about.htmlmirrors the structure of the existing pages: same head metadata (title, description, canonical URL, social-sharing tags), shared header/footer partials, page-hero + white content section, and the standard CTA block.page-hero--compact,section--about) tighten the gap between the heading and the text on this page only — sharedstyles.cssis untouched.partials.jsx, so About remains last when Try is restored.about.htmladded tositemap.xml.Verified locally
Created with the help of Claude Code
Summary by CodeRabbit
New Features
Documentation