ci(security): Trivy misconfig + fs scan gate — report-only (#1796)#1823
Draft
ktursunov wants to merge 1 commit into
Draft
ci(security): Trivy misconfig + fs scan gate — report-only (#1796)#1823ktursunov wants to merge 1 commit into
ktursunov wants to merge 1 commit into
Conversation
…uctorfabric#1796) New .github/workflows/security-trivy.yml runs trivy config (IaC + Dockerfile misconfig) and trivy fs (filesystem vulns, ignore-unfixed) at CRITICAL,HIGH on PRs to main + a nightly schedule + workflow_dispatch, aquasecurity/trivy-action pinned by SHA (v0.36.0), findings in the job summary. New .trivyignore carries 4 documented, tracked waivers (AVD-DS-0002, AVD-DS-0029, AVD-KSV-0118, AVD-KSV-0014) per constructorfabric#1340. Report-only first per the constructorfabric#1796 ratchet; a local baseline triage found all config misconfigs waived and the fs scan clean, so a follow-up flip to blocking + required checks is expected to be zero-disruption. Part of constructorfabric#1478; split from closed PR constructorfabric#1463. Signed-off-by: Konstantin Tursunov <Konstantin.Tursunov@constructor.tech> Co-authored-by: Constructor Studio <291158726+constructor-studio[bot]@users.noreply.github.com> Studio-Generated-By: Constructor Studio Studio-Source-Repo: https://github.com/constructorfabric/studio Constructor-Fabric: https://github.com/constructorfabric Studio-Version: skill=1.5.9, cli=1.5.9 Studio-Workflows: cf-plan,cf-analyze,cf-write-skills
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #1796 (part of security-scanner umbrella #1478; split from closed PR #1463).
What
.github/workflows/security-trivy.yml— two jobs,CRITICAL,HIGH, on PR→main+ nightlyschedule+workflow_dispatch, findings in the job summary:trivy-config— IaC + Dockerfile misconfiguration (scan-type: config,scan-ref: .).trivy-fs— filesystem vulnerabilities (scan-type: fs,ignore-unfixed: true).aquasecurity/trivy-actionpinned by SHA (@ed142fd…c25# v0.36.0)..trivyignore— 4 documented, tracked waivers → Security: trivy-config HIGH misconfigurations — root containers + frontend Deployment securityContext (waivers) #1340:AVD-DS-0002,AVD-DS-0029,AVD-KSV-0118,AVD-KSV-0014.Report-only first (the ratchet)
Both jobs run
exit-code: "0"— surfaced, non-blocking. A local baseline (Trivy v0.72.0) found:src/backend/Cargo.lockis scanned; Python (pyproject-only) and .NET (.csproj-only) deps have no committed lockfiles, so they are currently unscanned.Follow-ups
exit-code: "1"+ add both jobs as required status checks onmain, once the team agrees the baseline.trivy fscoverage — commit lockfiles (uv/poetry,packages.lock.json) or scan built images.Acceptance criteria (#1796)
.trivyignorewith documented, tracked waivers only