ci(helm): helm-validate workflow + CI render values (split 3/4 of #1317)#1464
ci(helm): helm-validate workflow + CI render values (split 3/4 of #1317)#1464SharedQA wants to merge 2 commits into
Conversation
…structorfabric#1317) Split out of constructorfabric#1317 per review. The helm slice: - .github/workflows/helm-validate.yml — Chart.yaml version/appVersion format guard, forbid :latest image tags, helm lint --strict (umbrella + service subcharts), full helm template render with CI values, kubeconform. - charts/insight/ci/ci-values.yaml — render-only placeholders (the chart leaves infra hosts/tags UNSET by design). Self-standing: runs helm/kubeconform directly (no Makefile), no docs/security/release files. Verified locally: helm template renders 21 objects, lint --strict clean. Signed-off-by: Kenan Salim <ks@constructor.tech>
|
Warning Review limit reached
More reviews will be available in 57 minutes and 15 seconds. Learn how PR review limits work. To continue reviewing without waiting, enable usage-based billing in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… (split 4/4) Per review, constructorfabric#1317 was too big (docs/security/helm/release). The other three concerns moved to dedicated PRs: - docs-gates -> constructorfabric#1462 - security-gates -> constructorfabric#1463 - helm-validate -> constructorfabric#1464 constructorfabric#1317 now carries only the release/quality slice: - .github/workflows/release-train.yml (version/publish train) - .github/workflows/backend-checks.yml (coverage ratchet folded in) - .github/workflows/e2e-bronze-to-api.yml (coverage note) - scripts/ci/enforce-quality-gates.sh (required-checks bootstrap) - Makefile (the local dev-loop aggregator) Merge order: this slice lands LAST. The Makefile's aggregate targets (check/ci-pr) and the enforce script reference the gates that now live in Signed-off-by: Kenan Salim <ks@constructor.tech> constructorfabric#1462/constructorfabric#1463/constructorfabric#1464, so they resolve once those merge to main and this rebases.
|
#1559 |
Split out of #1317 (too large to review as one). This is the helm slice.
What
.github/workflows/helm-validate.yml— blocking chart gate:version(X.Y.Z) +appVersion(build-tag) format guard (the---defect class).:latestimage tags in values.helm lint --strict(umbrella + service subcharts).helm templaterender with CI values +kubeconformon the output.charts/insight/ci/ci-values.yaml— render-only placeholders (the chart intentionally leaves infra hosts/tags UNSET and fail-fasts; these let the render/kubeconform gate run).Notes
helm templaterenders 21 objects,helm lint --strictclean.