Skip to content

test(team-view): cover column-header sorting in the members heatmap#201

Merged
mitasovr merged 1 commit into
mainfrom
test/members-heatmap-column-sort
Jul 15, 2026
Merged

test(team-view): cover column-header sorting in the members heatmap#201
mitasovr merged 1 commit into
mainfrom
test/members-heatmap-column-sort

Conversation

@mitasovr

Copy link
Copy Markdown
Contributor

Problem

The diff-coverage gate failed on #200 (77.8% < 80%): the revert re-introduced the column-sort branch of sortedRows (COLUMNS.findIndex lookup, index.tsx lines 386–387) as changed lines, and no test clicks a column header, so those lines were uncovered.

Change

Add a component test that:

  • sorts by a higher-is-better column ("Tasks closed") and asserts the row order flips (Bob 15 above Alice 8),
  • exercises the lower-is-better path ("Mean time to resolution") with missing bullet values to cover the null-handling fallback,
  • asserts the default "issues" sort ties break by name.

Verified locally: the previously missing lines now report hits in the coverage output, and the full vitest suite passes.

🤖 Generated with Claude Code

The diff-coverage gate on #200 flagged the column-sort branch of
sortedRows (COLUMNS.findIndex lookup) — the revert re-introduced those
lines and no test clicked a column header. Add a test that sorts by a
higher-is-better column, checks the row order flips, and exercises the
lower-is-better path with missing values.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Roman Mitasov <roman.mitasov@constructor.tech>
@mitasovr
mitasovr requested a review from a team as a code owner July 15, 2026 11:02
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@mitasovr, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 19 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 44506053-9412-4c71-9604-2c8672efac39

📥 Commits

Reviewing files that changed from the base of the PR and between 726b1cc and 5e46eeb.

📒 Files selected for processing (1)
  • src/components/widgets/v2/members-heatmap/index.test.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/members-heatmap-column-sort

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mitasovr
mitasovr merged commit 1a9850d into main Jul 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants