Skip to content

feat(ai): render ChatGPT Team (Codex + Chat) bullets in ai_adoption#160

Draft
mozhaev-dev wants to merge 1 commit into
mainfrom
feat/chatgpt-team-ai-bullets
Draft

feat(ai): render ChatGPT Team (Codex + Chat) bullets in ai_adoption#160
mozhaev-dev wants to merge 1 commit into
mainfrom
feat/chatgpt-team-ai-bullets

Conversation

@mozhaev-dev

Copy link
Copy Markdown
Contributor

Part of constructorfabric/insight#497

Render ChatGPT Team (Codex + Chat) bullets in ai_adoption

Adds the FE-only layout placement for the three new ChatGPT Team bullet metrics emitted by the analytics-api metric_catalog seed (insight PR feat/chatgpt-team-connectorm20260609_000002).

Since #66 wave 4 (199f2da) deleted the compile-in threshold-config.ts and made the wire metric_catalog the sole source of metric metadata (labels / sublabels / thresholds), this PR carries only layout composition — no metric metadata. Six lines in src/lib/insight/bullet-layout-groups.ts:

  • BULLET_LAYOUT_GROUPS: chatgpt_active → ai_members, codex_lines / codex_sessions → ai_codex_detail.
  • BULLET_DISPLAY_ORDER: the same three keys placed alongside the existing Codex / Claude-Code entries in the ai_adoption block.

The labels, sublabels, units and thresholds for these keys arrive over the wire from the catalog seed, so nothing else is needed FE-side.

Depends on the analytics-api catalog seed shipping (insight connector PR) for the metrics to appear in the response.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 50f44478-3f2b-4fb7-a8b3-62d700f96c61

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/chatgpt-team-ai-bullets

Comment @coderabbitai help to get the list of available commands and usage tips.

@mitasovr

Copy link
Copy Markdown
Contributor

Reviewed together with the backend PR (constructorfabric/insight#1282). The placement is consistent with the m20260609_000002 catalog seed keys, and merging this before the backend is safe (absent keys simply don't render). Three points:

  1. Who consumes ai_codex_detail? Neither v1 screen references it: team-bullet-sections.tsx renders only ai_members / ai_team_output / ai_acceptance from the AI section, and engineering-dashboard.tsx uses groups only for collaboration. The same is true for the existing ai_cursor_detail / ai_cc_detail / ai_web, so the pattern is consistent — but per this file's own docstring the v2 surfaces "don't read this map" either. Could you confirm which surface actually renders the *_detail groups, so codex_lines / codex_sessions don't silently end up displayed nowhere?
  2. chatgpt_active lands in ai_members and will render in the v1 team view's left column — but the section header in team-bullet-sections.tsx still reads "Cursor · Claude Code · Codex", with no mention of ChatGPT. Worth updating in this PR since it's the layout PR.
  3. Nit: the file docstring says "ai_adoption (7 groups)" — it's 8 now with ai_codex_detail.

FE-only layout placement for the ChatGPT Team metric_keys served by the
analytics-api metric_catalog (insight #1282): chatgpt_active → ai_members,
codex_lines / codex_sessions → ai_codex_detail, with matching display-order
entries. Labels/sublabels/thresholds come from the wire catalog (post-#82,
threshold-config.ts deleted). Rebased onto current main as a single signed
commit (DCO).

Part of constructorfabric/insight#497.

Signed-off-by: Sergey Mozhaev <Sergey.Mozhaev@constructor.tech>
@mozhaev-dev
mozhaev-dev force-pushed the feat/chatgpt-team-ai-bullets branch from d1b8061 to 98c2174 Compare June 12, 2026 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants