refactor: Remove dylints #4183
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Gears manifest. Used by `cargo gears` CLI for linting and other tasks. | ||
| # See https://github.com/constructorfabric/cargo-gears for documentation. | ||
|
|
||
| [apps.gears-rust.dev] | ||
| config = "lint.yml" | ||
| gears = [] | ||
|
|
||
|
Comment on lines
+4
to
+7
There was a problem hiding this comment. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Verify the location of lint.yml
fd lint.ymlRepository: constructorfabric/gears-rust Length of output: 182 🏁 Script executed: #!/bin/bash
set -euo pipefail
# Inspect the manifest entry and the code that loads its config path
git ls-files 'Gears.toml' 'config/lint.yml' | sed -n '1,20p'
echo '--- Gears.toml ---'
cat -n Gears.toml
echo '--- search for config path handling ---'
rg -n 'config\s*=|lint\.yml|Gears\.toml|cargo-gears|manifest' -S .Repository: constructorfabric/gears-rust Length of output: 50385 🏁 Script executed: #!/bin/bash
set -euo pipefail
# Inspect the manifest and any path resolution logic for the config field
cat -n Gears.toml
echo '---'
rg -n 'config\s*=|config path|resolve.*config|manifest.*path|from_manifest|PathBuf::from|canonicalize' -S .Repository: constructorfabric/gears-rust Length of output: 50385 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo '--- repo files around manifest/gear config ---'
git ls-files | rg '(^|/)(Gears\.toml|Cargo\.toml|.*gear.*|.*manifest.*|.*config.*|src/|crates/)' | head -n 200
echo '--- Gears.toml ---'
cat -n Gears.toml
echo '--- find Rust files mentioning Gears.toml or config field ---'
rg -n --glob '!**/target/**' --glob '!**/*.min.*' --glob '!**/dist/**' --glob '!**/build/**' \
'Gears\.toml|config\s*=|lint\.yml|cargo-gears|manifest' \
src .github crates . 2>/dev/null | head -n 200Repository: constructorfabric/gears-rust Length of output: 11482 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo '--- repo files around manifest/gear config ---'
git ls-files | rg '(^|/)(Gears\.toml|Cargo\.toml|.*gear.*|.*manifest.*|.*config.*|src/|crates/)' | head -n 200
echo '--- Gears.toml ---'
cat -n Gears.toml
echo '--- find Rust files mentioning Gears.toml or config field ---'
rg -n --glob '!**/target/**' --glob '!**/*.min.*' --glob '!**/dist/**' --glob '!**/build/**' \
'Gears\.toml|config\s*=|lint\.yml|cargo-gears|manifest' \
src crates .github 2>/dev/null | head -n 200Repository: constructorfabric/gears-rust Length of output: 11482 🏁 Script executed: #!/bin/bash
set -euo pipefail
printf 'top-level files:\n'
git ls-files | awk -F/ 'NF==1{print}' | sort
printf '\npossible source files:\n'
git ls-files | rg '^(src|crates|apps)/.*\.(rs|toml)$' | head -n 200
printf '\nmanifest-related files:\n'
git ls-files | rg 'Gears\.toml|lint\.yml|Cargo\.toml|manifest' | head -n 200Repository: constructorfabric/gears-rust Length of output: 5038 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo '--- exact references to lint.yml / Gears.toml in tracked source ---'
git ls-files '*.rs' '*.toml' | xargs rg -n --no-messages 'Gears\.toml|lint\.yml|config\s*=' | head -n 200Repository: constructorfabric/gears-rust Length of output: 22926 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo '--- Rust files mentioning manifest/config logic ---'
git ls-files '*.rs' | xargs rg -n --no-messages 'Gears\.toml|config\s*=|lint\.yml|PathBuf|manifest|toml' | head -n 200
echo '--- tree of likely source roots ---'
fd -t f -d 2 . .Repository: constructorfabric/gears-rust Length of output: 20649 🏁 Script executed: #!/bin/bash
set -euo pipefail
# Search only Rust sources for manifest/config handling.
rg -n --glob '*.rs' --glob '!**/target/**' \
'Gears\.toml|config\s*=|lint\.yml|PathBuf::from|canonicalize|manifest' \
.Repository: constructorfabric/gears-rust Length of output: 50385 Point 🤖 Prompt for AI Agents |
||
| [apps.gears-rust.dev.lint] | ||
| fmt = false # already handled by `make fmt` | ||
| clippy = false # already handled by `make clippy` | ||
|
|
||
| [apps.gears-rust.dev.lint.dylint] | ||
| enabled = true | ||
| # Remove entries as violations are fixed or cargo-gears-lints is updated. | ||
| skip = [ | ||
| # New lint not yet addressed in this repo. | ||
| "de0504_client_versioning", | ||
| # Path exclusion logic in cargo-gears-lints uses "modules/" prefix but this | ||
| # repo uses "gears/". Skipped until cargo-gears-lints adds "gears/" support. | ||
| "de1101_tests_in_separate_files", | ||
| # Scope broadened from /contract/ to /domain/ in cargo-gears-lints. | ||
| # Pre-existing code in domain/ layers needs migration. | ||
| "de0101_no_serde_in_contract", | ||
| "de0102_no_toschema_in_contract", | ||
| ] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| # Minimal config file required by the Gears manifest for linting. | ||
| server: {} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.